This repository has been archived by the owner on Mar 12, 2022. It is now read-only.
[Internal] Add Ruby support for logical types #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only logical types that map directly to Ruby standard library types are supported: * `date` maps to Date; * `timestamp-millis` and `timestamp-micros` map to Time.
* Move logical_type determination into `.real_parse`. * `#logical_type` now returns the logical type name. * Change logical type "adapters" to modules since there will be no instances. * Parity with Java conversion tests.
tjwp
force-pushed
the
tjwp/ruby-logical-types
branch
from
7b56cca to
f1a6168
Compare
|
Closing to submit to upstream. |
tjwp
pushed a commit
that referenced
this pull request
Jun 2, 2017
Added more tests and fixed a couple of bugs. Also formatted the code
tjwp
pushed a commit
that referenced
this pull request
Jan 6, 2019
This closes apache#243 commit b2a5607 Merge: 500c28c 54fc3f5 Author: Daniel Kulp <[email protected]> Date: Mon Dec 3 14:46:47 2018 -0500 Merge branch 'master' into master commit 500c28c Author: Daniil Guitelson <[email protected]> Date: Fri Sep 1 17:37:10 2017 +0300 AVRO-2069: Use primitive fields in generated getters & setters in Java code Fix broken unit tests in TestSpecificCompilerTool after migrating to org.junit.Test commit 35b891e Merge: c642ada 189368e Author: Daniil Gitelson <[email protected]> Date: Fri Sep 1 17:33:13 2017 +0300 Merge pull request #1 from apache/master Sync up with origin repository commit c642ada Author: Daniil Guitelson <[email protected]> Date: Wed Aug 30 18:37:41 2017 +0300 AVRO-2069: Use primitive fields in generated getters & setters in Java code Fix broken unit tests in TestSpecificCompilerTool commit 3414eae Author: Daniil Guitelson <[email protected]> Date: Tue Aug 29 12:13:42 2017 +0300 AVRO-2069: Use primitive fields in generated getters & setters in Java code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit preserves the original work on logical types by dasch.
The second commit is mostly intended to address the outstanding feedback on apache#44:
The main change that I've made from the original work is to expose the name of the logical type as a
#logical_typemethod. Previously, it returned the "type" used for encoding and decoding. I've renamed that tological_type_adapterand changed those classes to modules.