Alter type functions #111
Merged
Alter type functions #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-kaspar
approved these changes
Sep 12, 2017
| @@ -352,6 +352,75 @@ This is required for some SQL operations that cannot be run within a transaction | |||
|
|
|||
| ----------------------------------------------------- | |||
|
|
|||
| #### `pgm.renameType( type_name, new_type_name )` | |||
|
|
|||
| > Rename a data type - [postgres docs](http://www.postgresql.org/docs/current/static/sql-altertype.html) | |||
There was a problem hiding this comment.
All other comment verbs are in 3rd person (adds / sets), just this one (and the one below) is not (i.e. is without the trailing 's').
README.md
Outdated
|
|
||
| #### `pgm.dropTypeAttribute( type_name, attribute_name, options )` | ||
|
|
||
| > Adds an attribute to data type - [postgres docs](http://www.postgresql.org/docs/current/static/sql-altertype.html) |
There was a problem hiding this comment.
Looks like copy / paste comment. The function name is 'drop...', the comments says 'Adds ...'.
| **Arguments:** | ||
| - `type_name` _[string]_ - name of the type | ||
| - `attribute_name` _[string]_ - name of the attribute | ||
| - `attribute_type` _[string]_ - new type of the attribute |
There was a problem hiding this comment.
3rd parameter in the definition says 'options', here you have 'attribute_type'.
| **Arguments:** | ||
| - `type_name` _[string]_ - name of the type | ||
| - `value` _[string]_ - value to add to list | ||
| - `options` _[object]_ - options: |
There was a problem hiding this comment.
This parameter is not listed in the function declaration above.
|
|
||
| #### `pgm.renameTypeAttribute( type_name, attribute_name, new_attribute_name )` | ||
|
|
||
| > Rename an attribute of data type - [postgres docs](http://www.postgresql.org/docs/current/static/sql-altertype.html) |
There was a problem hiding this comment.
Rename --> Renames? (same as the first comment here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109