Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of enum values #293

Merged
merged 9 commits into from
Jul 12, 2018
Merged

Renaming of enum values #293

merged 9 commits into from
Jul 12, 2018

Conversation

Shinigami92
Copy link
Collaborator

ALTER TYPE name RENAME VALUE existing_enum_value TO new_enum_value;

made possible by https://commitfest.postgresql.org/10/588
solution found on https://stackoverflow.com/a/45444822/6897682

this is only compatible with PostgreSQL 10+

docu: https://www.postgresql.org/docs/10/static/sql-altertype.html

@Shinigami92
Copy link
Collaborator Author

Should I also write tests and documentation, or do you prefer to do it yourself

@dolezel
Copy link
Contributor

dolezel commented Jul 9, 2018

Would be great if you can add tests, documentation and typescript definitions, but I can do it, if you do not have time...

@Shinigami92
Copy link
Collaborator Author

I have the time and I would like to add the tests and documentation myself
Thus, I come a little deeper into this project
At least I have time tomorrow evening (Germany CEST 18:00)
(I have two accounts @chq-synaix from work, and this as my own hobby / free time account)

@Shinigami92
Copy link
Collaborator Author

Finally! 🎉
The test was helpful. Now everything is escaped correctly.
Ready for review

Copy link
Contributor

@dolezel dolezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dolezel dolezel merged commit 7a9e29c into salsita:master Jul 12, 2018
@dolezel dolezel changed the title implemented renaming of enum values Renaming of enum values Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants