-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decamelize #472
Decamelize #472
Conversation
Files changed: 124 I am not reviewing this PR as is. There is a ton of totally unrelated changes. So if you want me to review it, please split the PR to parts relevant to the Decamelize topic (in dedicated PR to review), and the rest (that can be probably merged without review (guessing the changes are generated by some linting tool anyway)). |
bcc0a99
to
4f2a792
Compare
I've split it with commits. Only relevant to decamelize is 4f2a792 |
It is still big, but at least the half of the changes are gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not verify all the details that the text-generating functions still do what they did before (hope tests will cover that).
But I don't like this PR (yet). See the two comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments :-).
LGTM.
Fixes #464
It has great potential to break something, so I'm not sure I want to merge it :/