Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide format script #749

Merged
merged 3 commits into from
May 23, 2021
Merged

Provide format script #749

merged 3 commits into from
May 23, 2021

Conversation

Shinigami92
Copy link
Collaborator

This adds a format script to package.json's scripts block, so you can run npm run format and all supported files in the project will be formatted.

Folders like dist needs to be excluded because they are auto-generated.

The both other ignored files have a strange semicolon before the first brace in front of the async, so I just ignored these both files for now.

Copy link
Contributor

@goce-cz goce-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for your contribution, it is very appreciated.

I left a single comment which resonates with my general approach to code-formating and linting:

If you think that rules are useful and important, define them well and then follow them. If you constantly need to break them, it's either because the rules are wrong or because you're to sloppy.

IMO this particular case fits more into the second category. Immediately executed anonymous functions are not something you use on a daily basis, so having a bit more verbose version won't kill anybody.

.prettierignore Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 self-assigned this May 16, 2021
@Shinigami92 Shinigami92 requested a review from littlewhywhat May 16, 2021 17:08
Copy link
Contributor

@littlewhywhat littlewhywhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@littlewhywhat littlewhywhat merged commit e65c9d3 into salsita:master May 23, 2021
@Shinigami92 Shinigami92 deleted the provide-format-script branch May 23, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants