Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom env file path #759

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Add custom env file path #759

merged 7 commits into from
Mar 18, 2021

Conversation

vanpana
Copy link
Contributor

@vanpana vanpana commented Mar 17, 2021

Loads the "env" file from a custom path if your file containing environment variables is located elsewhere.

  • added a new commandline argument, envPathArg.
  • Add the config to the dotenv config only if it has been set, otherwise don't change anything. (link to dotenv path option)

@vanpana
Copy link
Contributor Author

vanpana commented Mar 17, 2021

@goce-cz can you please take a look at this?

bin/node-pg-migrate Outdated Show resolved Hide resolved
bin/node-pg-migrate Outdated Show resolved Hide resolved
bin/node-pg-migrate Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the old-label enhancement Functionality that enhances existing features label Mar 17, 2021
@vanpana vanpana requested a review from Shinigami92 March 18, 2021 08:09
@Shinigami92 Shinigami92 requested a review from goce-cz March 18, 2021 08:23
Copy link
Contributor

@goce-cz goce-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Please just adapt the cli.md as well:

  • add the option to the Configuration section
  • you might also mention it near where it says:

If a .env file exists, it will be loaded using dotenv (if installed) when running the node-pg-migrate binary.

@vanpana vanpana requested a review from goce-cz March 18, 2021 11:10
Copy link
Contributor

@goce-cz goce-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@vanpana
Copy link
Contributor Author

vanpana commented Mar 18, 2021

I am not authorized to merge, so if you can help me do it, that'd be great! 🙏

@goce-cz goce-cz merged commit db3f901 into salsita:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-label enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants