Enable string functions and arrays as default column values

[arthurfranca]

No description provided.

[dolezel]

Sorry, but I do not quite understand purpose of this PR.
Are you trying to something like:

pgm.createTable('t', {
  a1: { type: 'integer[]', default: pgm.func("'{1, 2, 3}'") },
  a2: { type: 'integer[]', default: pgm.func('ARRAY[1, 2, 3]') },
});

?

[arthurfranca]

The purpose of the 2 commits is to enable these two defaults (without using pgm.func):

pgm.createTable('table', {
  id: { type: 'uuid', default: 'gen_random_uuid()' },
  table_2_ids: { type: uuid[]', default: [] }
})

Notice that the array isn't a string, but an array literal
It's following postgresql documentation and converting [1,2] to '{1,2}'

[dolezel]

But that is the purpose of pgm.func. Escaping and unescaping string is worse option. It will introduce new bugs when it will unescape strings that should not be unescaped.
If you want some string that should not be escaped, just use pgm.func.

[arthurfranca]

@dolezel what about the array literal as default? I don't see a problem as there's special treatment to booleans and nulls. I mean, you can say default: null and default: true instead of 'NULL' and 'true' which are expected by postgres.

It seems better using [1, 2, 3] instead of pgm.func('ARRAY[1, 2, 3]') as with null instead of 'NULL'.

Also, the added tests were discarded =0.

[dolezel]

Yes, that is a good idea, so please change your code to
if (Array.isArray(val)) return `ARRAY[${val.map(escapeValue).join(',')}]`;
and keep relevant test.
Thanks!

[arthurfranca]

@dolezel done. Used your code with a small addition to allow multidimensional arrays, so that the added test pass.

[dolezel]

👍