refactor: reduce repeated code in state machine #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces repeated boilerplate code around handling taking/putting the state with a wrapper type. This wrapper type moves the state machine itself into a closure, allowing nice things like using ? to return errors and other early returns. It also makes simple an "Errored" state for the state machine so that calling the state machine after it's already returned an error is no longer a panic. Signed-off-by: Nick Stevens <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 81.96% 82.53% +0.57%
==========================================
Files 5 6 +1
Lines 793 796 +3
==========================================
+ Hits 650 657 +7
+ Misses 143 139 -4
Continue to review full report at Codecov.
|
posborne
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces repeated boilerplate code around handling taking/putting the state with a wrapper type. This wrapper type moves the state machine itself into a closure, allowing nice things like using
?to return errors and other early returns. It also makes simple an "Errored" state for the state machine so that calling the state machine after it's already returned an error is no longer a panic.Other than adding early returns where appropriate, I did not change state machine behavior in this commit. Unfortunately it doesn't look like Github diff is aligning very well, but something to keep in mind while reviewing.