Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Add Python 2 unicode string literals in YAML renderer #52350

Closed
3 tasks
Ch3LL opened this issue Mar 28, 2019 · 0 comments
Closed
3 tasks

Re-Add Python 2 unicode string literals in YAML renderer #52350

Ch3LL opened this issue Mar 28, 2019 · 0 comments
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 severity-critical top severity, seen by most users, serious issues severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around v2019.2.1 unsupported version
Milestone
Approved

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 28, 2019

Description of Issue/Question

This PR #48309 deprecated support for python2 unicode string style in yaml. This issue is to track adding this support back into salt for the 2019.2.1 release, gated via a config option. We want to keep the default behavior, but add a config option that can enable the old yaml support.

  • add a new yaml loader that uses the old way of handling python2 unicode string literals and can be turned on with a config optoin
  • add logging to each state that needs to be fixed to use the tojson syntax to help people move onto the new system.
  • update 2019.2.1 release notes with notice about this new config option
@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around severity-critical top severity, seen by most users, serious issues P1 Priority 1 v2019.2.1 unsupported version labels Mar 28, 2019
@Ch3LL Ch3LL added this to the Approved milestone Mar 28, 2019
@garethgreenaway garethgreenaway mentioned this issue Apr 5, 2019
Merged
@garethgreenaway garethgreenaway added the fixed-pls-verify fix is linked, bug author to confirm fix label May 3, 2019
@Ch3LL Ch3LL closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 severity-critical top severity, seen by most users, serious issues severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around v2019.2.1 unsupported version
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@garethgreenaway @Ch3LL