Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Support for old yaml render #52427

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Adding support back in with, a gated configuration option, for the old YAML Loader.

What issues does this PR fix or reference?

#52350

Previous Behavior

With the recent change in 2019.2 to the yaml render, unicode string literals in YAML are no longer supported.

New Behavior

This change added a configuration option to use the older yaml render.

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway added the v2019.2.1 unsupported version label Apr 5, 2019
@max-arnold
Copy link
Contributor

Have you considered using the existing use_superseded configuration namespace for this feature flag?

@garethgreenaway
Copy link
Contributor Author

@max-arnold I looked at using use_superseded but it's designed for individual functions within modules, with this we want to use the older version of the YAMLLoader class.

@dwoz dwoz merged commit 6040282 into saltstack:2019.2 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2019.2.1 unsupported version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants