[TECH DEBT] Deprecate ESXi execution modules in favor of VMware Salt extensions

[dmurphy18]

Description of the tech debt to be addressed, include links and screenshots

Given these execution modules currently do not get much attention, esp. since 2016, and all VMware support is currently occurring on the VMware extensions. Any functionality currently provided by these modules and not support by VMware extensions, should be added to VMware extensions.

Should have a single point of development for VMware support, which is currently VMware extensions.
Removes chance of confusion as to which execution module to use.

Also note that the ESXi execution modules do not fully function with currently released VMware software, since they have not been maintained sufficiently to kleep up to date with VMware API changes.

Execution Modules to deprecate:

• esxcluster.py
• esxdatacenter.py
• esxi.py
• esxvm.py

Note associated state files:

• esxcluster.py
• esxdatacenter.py
• esxi.py
• esxvm.py

These state file will need to be checked to ensure they function with VMware Salt Extensions.

[dmurphy18]

Note: these execution modules were the basis for the start of the VMware Salt Extensions, hence expect no issues with compatibility, but have to check.

[dmurphy18]

From initial review of the state files provided in Salt (salt/states/esxcluster.py), the same named state function is not provided in VMware Salt Extensions, hence expect need to port or alias similar functionality in VMware Salt Extensions.

Also what to do about the execution module vsphere.py

These files also expect to be operating on a proxy-minion, various appropriately named esxvm, esxdatacenter, etc.