[TECH DEBT] Deprecation of ESXi in core Salt in favor of Salt VMware extensions for 3008 release #63002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
changed the title
MKLeb
previously approved these changes
Nov 2, 2022
MKLeb
reviewed
Nov 2, 2022
Ch3LL
suggested changes
Nov 3, 2022
changelog/62754.fixed
Outdated
| @@ -0,0 +1 @@ | |||
| Deprecate core ESXi and associated states and modules, vcenter and vsphere support in favor of Salt VMware Extensions | |||
There was a problem hiding this comment.
The file extension should be .deprecated since you are deprecating modules.
There was a problem hiding this comment.
Thanks for the catch, fixed it
Ch3LL
approved these changes
Nov 3, 2022
|
merging since tests were passing before editing changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deprecates use of ESXi and associated esxcluster, esxdatacenter, esxvm, vcenter and vsphere in core Salt, in favor of using the Salt VMware extensions.
The current core esxi, esxcluster, esxdatacenter, esxvm etc have not been maintained by Salt for some time, and the versions of pyvmomi is circa v4/5, current version is 7, and functionality has changed and not all functionality currently works. Salt is supporting the Salt VMware extensions and this is were the ESXi functionality should be supported rather than core Salt. This is also inline with moving current functionality to extensions.
What issues does this PR fix or reference?
Fixes: #62754, #62526, #62004, #61097
New Behavior
Update Salt VMware Extensions to support required functionality, if it does not currently exist in Salt VMware extensions. Deprecation notice allows for two major versions of Salt to have needed functionality in the VMware extensions
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.