Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] x509_v2 create_private_key / create_crl: unknown kwargs __pub_fun... #64232

Closed
4 tasks done
lkubb opened this issue May 4, 2023 · 1 comment · Fixed by #64233
Closed
4 tasks done

[BUG] x509_v2 create_private_key / create_crl: unknown kwargs __pub_fun... #64232

lkubb opened this issue May 4, 2023 · 1 comment · Fixed by #64233
Assignees
Labels
Bug broken, incorrect, or confusing behavior Execution-Module needs-triage

Comments

@lkubb
Copy link
Contributor

lkubb commented May 4, 2023

Description
salt-call x509.create_private_key (and create_crl) check if unknown kwargs are passed (needed since implementing the compatibility layer) and raise an exception if any are found. This check fails to filter out internal kwargs.

Setup

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • onedir packaging
  • used bootstrap to install

Steps to Reproduce the behavior
enable x509_v2

features:
  x509_v2: true

salt-call x509.create_private_key

Expected behavior
prints private key

Screenshots

salt.exceptions.SaltInvocationError: Unrecognized keyword arguments: ['__pub_fun', '__pub_pid', '__pub_jid', '__pub_tgt']

Versions Report
still on 3005.1, but with new x509_v2 modules found in 3006.0

Additional context
This was not caught in CI since only create_certificate is run as part of the integration tests, the rest is executed in functional ones.

@lkubb lkubb added Bug broken, incorrect, or confusing behavior needs-triage labels May 4, 2023
@lkubb lkubb changed the title [BUG] x509_v2 create_private_key / create_crl: unknown kwargs __pub_fun... [BUG] x509_v2 create_private_key / create_crl: unknown kwargs __pub_fun... May 4, 2023
@anilsil anilsil added this to the Sulfur v3006.2 milestone May 5, 2023
@lkubb
Copy link
Contributor Author

lkubb commented May 18, 2023

Fixed by #64233

@lkubb lkubb closed this as completed May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants