Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix x509_v2 unknown salt-internal kwargs #64233

Merged
merged 2 commits into from
May 10, 2023

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented May 4, 2023

What does this PR do?

Filters kwargs prefixed with _ before checking if any unknown ones are present.

What issues does this PR fix or reference?

Fixes: #64232

Previous Behavior

exception

New Behavior

works

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@lkubb lkubb requested a review from a team as a code owner May 4, 2023 14:27
@lkubb lkubb requested review from MKLeb and removed request for a team May 4, 2023 14:27
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix x509_v2 unknown salt-internal kwargs [master] Fix x509_v2 unknown salt-internal kwargs May 4, 2023
@lkubb lkubb temporarily deployed to ci May 4, 2023 14:43 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 4, 2023 14:43 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 4, 2023 14:43 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 4, 2023 15:42 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 4, 2023 15:42 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 4, 2023 15:42 — with GitHub Actions Inactive
@lkubb lkubb changed the base branch from master to 3006.x May 4, 2023 22:39
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Fix x509_v2 unknown salt-internal kwargs [3006.x] Fix x509_v2 unknown salt-internal kwargs May 4, 2023
@lkubb lkubb changed the base branch from 3006.x to master May 4, 2023 22:39
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [3006.x] Fix x509_v2 unknown salt-internal kwargs [master] Fix x509_v2 unknown salt-internal kwargs May 4, 2023
@anilsil anilsil added this to the Sulfur v3006.2 milestone May 5, 2023
@lkubb lkubb temporarily deployed to ci May 5, 2023 09:05 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 5, 2023 09:05 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 5, 2023 09:05 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 5, 2023 10:03 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 5, 2023 10:03 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 5, 2023 10:03 — with GitHub Actions Inactive
@lkubb lkubb changed the base branch from master to 3006.x May 6, 2023 22:00
@lkubb lkubb force-pushed the x509-v2-kwargs branch from 1256933 to f8f7ed5 Compare May 6, 2023 22:00
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Fix x509_v2 unknown salt-internal kwargs [3006.x] Fix x509_v2 unknown salt-internal kwargs May 6, 2023
@lkubb lkubb temporarily deployed to ci May 6, 2023 22:16 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 6, 2023 22:16 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci May 6, 2023 22:16 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] x509_v2 create_private_key / create_crl: unknown kwargs __pub_fun...
3 participants