You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The saltstack-formulas/template-formula by default makes heavy use of log.debug etc (and slsutil.merge, different issue). Trying to apply such a formula via Salt-SSH, one is tempted to reconsider one's life choices since each of the couple dozen log.debug calls for each .sls file that includes map.jinja results in a shimmed call via a new SSH connection.
Setup
irrelevant
Steps to Reproduce the behavior
$ salt-ssh my_minion log.debug "this should not result in a shimmed call" -l debug 2> repro_log
$ grep -A 1 'Performing shimmed, blocking command as follows' repro_log[DEBUG ] Performing shimmed, blocking command as follows:log.debug this should not result in a shimmed call
Expected behavior
The log calls being processed/dropped locally
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
Salt Version:
Salt: 3006.4Python Version:
Python: 3.10.13 (main, Oct 4 2023, 21:54:22) [GCC 11.2.0]Dependency Versions:
cffi: 1.14.6cherrypy: unknowndateutil: 2.8.1docker-py: Not Installedgitdb: Not Installedgitpython: Not InstalledJinja2: 3.1.2libgit2: Not Installedlooseversion: 1.0.2M2Crypto: Not InstalledMako: Not Installedmsgpack: 1.0.2msgpack-pure: Not Installedmysql-python: Not Installedpackaging: 22.0pycparser: 2.21pycrypto: Not Installedpycryptodome: 3.9.8pygit2: Not Installedpython-gnupg: 0.4.8PyYAML: 6.0.1PyZMQ: 23.2.0relenv: 0.13.12smmap: Not Installedtimelib: 0.2.4Tornado: 4.5.3ZMQ: 4.3.4System Versions:
dist: rocky 9.2 Blue Onyxlocale: utf-8machine: x86_64release: 5.14.0-284.18.1.el9_2.x86_64system: Linuxversion: Rocky Linux 9.2 Blue Onyx
Additional context
Copying the logmod execution module into a wrapper reduces runtime from practically infinite to a couple of seconds.
Alternatives you have considered for comedic effect
Somehow warping spacetime to skip to the hopefully finite end of the run.
Adding a rule to Pylint in addition to the one about f-strings in log calls.
The text was updated successfully, but these errors were encountered:
Description
The
saltstack-formulas/template-formula
by default makes heavy use oflog.debug
etc (andslsutil.merge
, different issue). Trying to apply such a formula via Salt-SSH, one is tempted to reconsider one's life choices since each of the couple dozenlog.debug
calls for each.sls
file that includesmap.jinja
results in a shimmed call via a new SSH connection.Setup
irrelevant
Steps to Reproduce the behavior
Expected behavior
The log calls being processed/dropped locally
Screenshots
$ find /opt/saltstack/salt/lib/python3.10/site-packages/salt/client/ssh/wrapper/ -name logmod.py
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Additional context
Copying the
logmod
execution module into a wrapper reduces runtime from practically infinite to a couple of seconds.Alternatives you have considered for comedic effect
Somehow warping spacetime to skip to the hopefully finite end of the run.
Adding a rule to Pylint in addition to the one about f-strings in log calls.
The text was updated successfully, but these errors were encountered: