-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3007.x] Update SSH wrappers, wrap more funcs #65517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Update SSH wrappers, wrap more funcs
[3006.x] Update SSH wrappers, wrap more funcs
Nov 6, 2023
salt-project-bot-prod-environment
bot
changed the title
[master] Update SSH wrappers, wrap more funcs
[3007.x] Update SSH wrappers, wrap more funcs
Jan 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cp.*
functions.slsutil
wrapperdefaults
wrapperlog[mod]
wrappercmdmod
wrapper forcmd.script
cp.cache_file
add the respective files to the filerefs archive that is sent to the minion during state runsBased on #64576, which would have to be merged beforehand.Was merged.Also substantially increases test coverage on the
cp
wrapper (Ref #64842). 23% -> >90%Note:
tests/pytests/integration/ssh/test_saltcheck.py::test_saltcheck_state
is failing, but unrelated to this PR.git bisect
shows it has been failing since 639ec02. -> reported as #65574What issues does this PR fix or reference?
Fixes: #61100
Fixes: #56441
Fixes: #65067
Fixes: #61143
Fixes: #50196
Fixes: #48067
Fixes: #51605
Fixes: #65630
Partially: #61426
Helps with: #31531
Helps with: #19564
Previous Behavior
salt-ssh
than usualextra_filerefs
before applying states, either via CLI param or in the Saltfile. This PR allows to declare those dependencies in the state files themselves.New Behavior
Works mostly the same as regular Salt.
Merge requirements satisfied?
Commits signed with GPG?
Yes