Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] auto discovery of ssh, scp and ssh-keygen binaries. #66205

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

ctrix
Copy link

@ctrix ctrix commented Mar 12, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes: #66204

Previous Behavior

salt-ssh was using aliased scripts when running ssh, scp and ssh-keygen

New Behavior

ssh, scp and ssh-keygen paths are discovered and the original ssh binaries are used.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@ctrix ctrix requested a review from a team as a code owner March 12, 2024 08:33
@ctrix ctrix requested review from twangboy and removed request for a team March 12, 2024 08:33
Copy link

welcome bot commented Mar 12, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title auto discovery of ssh, scp and ssh-keygen binaries. [master] auto discovery of ssh, scp and ssh-keygen binaries. Mar 12, 2024
@twangboy
Copy link
Contributor

Hey, @ctrix , this looks great. Would you mind writing a test case and a changelog for this?

@dwoz
Copy link
Contributor

dwoz commented Mar 13, 2024

Should this go into 3006.x?

@Akm0d Akm0d force-pushed the discover_ssh_tools_path branch from 3a4c4a2 to 1b48f91 Compare April 12, 2024 21:33
@Akm0d Akm0d self-assigned this Apr 12, 2024
@dwoz dwoz merged commit 9a166d8 into saltstack:3006.x Apr 18, 2024
181 checks passed
Copy link

welcome bot commented Apr 18, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh uses hardcoded paths for ssh, scp and ssh-keygen
5 participants