Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when saltwinshell is missing #46588

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Don't crash when saltwinshell is missing #46588

merged 2 commits into from
Mar 21, 2018

Conversation

UtahDave
Copy link
Contributor

What does this PR do?

Don't crash when saltwinshell is missing

Tests written?

No

Commits signed with GPG?

Yes

@ghost ghost self-requested a review March 16, 2018 21:54
thatch45
thatch45 approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@thatch45 thatch45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was a lot easier then we thought at first eh?

@rallytime
Copy link
Contributor

re-run py3

@UtahDave UtahDave force-pushed the no_crash_winshell branch from c1c258a to b7842a1 Compare March 21, 2018 00:32
@cachedout cachedout merged commit 4e7466a into saltstack:2017.7 Mar 21, 2018
@UtahDave UtahDave deleted the no_crash_winshell branch March 22, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rallytime rallytime rallytime approved these changes

@thatch45 thatch45 thatch45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UtahDave @rallytime @thatch45 @cachedout