Use prune option in Pygit2 provider when fetching #49984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terminalmage
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
I like this, but I'm trying to move away from version checks when I can, the reason being that if the versioning ends up being determined via some sort of git describe logic (for those installing pygit2 from the upstream project's master branch), it may interfere with this kind of version check. Here are some recommended changes that can help us avoid explicit version checking and instead rely on the attributes we know should be available.
Thanks very much!
Pygit2 version 0.26.2 added support for pruning when fetching. In this way Pygit2 provider will no longer need to leverage git commanand line utility for pruning the remote. Signed-off-by: Cristian Hotea <[email protected]>
chotea
force-pushed
the
gitfs_pygit2_prune
branch
from
d8af165 to
f480fea
Compare
|
@terminalmage Re-review requested. |
terminalmage
approved these changes
Oct 18, 2018
Ch3LL
added
the
bugfix-bckport
Ch3LL
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pygit2 version 0.26.2 added support for pruning when fetching.
In this way Pygit2 provider will no longer need to leverage
git command line utility for pruning the remote.
Signed-off-by: Cristian Hotea [email protected]
Tests written?
No
Commits signed with GPG?
No