Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The etcd returner is using the wrong API due to a refactor of salt.utils.etcd_util. #51363

Merged
merged 82 commits into from
Jun 17, 2019
Merged

The etcd returner is using the wrong API due to a refactor of salt.utils.etcd_util. #51363

Changes from 80 commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
c55df2f
Apparently some random guy in 2015 re-factored everything etcd-relate…
arizvisa Jan 22, 2019
71e0882
Modified some of the etcd returner to handle missing keys in a more s…
arizvisa Jan 30, 2019
fb51f29
Updated the etcd returner to use the python-etcd api properly by catc…
arizvisa Feb 5, 2019
6050a40
Access to the EtcdResult.children property was deprecated for a new p…
arizvisa Feb 5, 2019
37d0f70
Updated the autodocs for all the functions in the etcd returner.
arizvisa Feb 5, 2019
4c0730f
Added an implementations of save_minions() to the etcd returners, re-…
arizvisa Feb 5, 2019
7a1deda
Fixed some necessary/missing characters in the etcd returner.
arizvisa Feb 5, 2019
b47b992
Updated the etcd returner to not use repr() when logging (instead opt…
arizvisa Feb 5, 2019
89a492d
Updated the returner() function in the etcd returner to aggregate all…
arizvisa Feb 5, 2019
459ea02
Fixed a type-o that resulted in the wrong module being called in the …
arizvisa Feb 5, 2019
96ddfa0
Fixed some PyLint issues in the etcd returner.
arizvisa Feb 5, 2019
7a4bacf
Grr. Removed a stray comma from the etcd returner.
arizvisa Feb 6, 2019
9fef68b
Added an implementation of event_return for the returners/etcd_return…
arizvisa Jan 22, 2019
12c4bbf
Fixed lint errors in the returners/etcd_return.py module.
arizvisa Jan 28, 2019
9a12341
Changed the format-strings in `event_return()` to format-specs for Py…
arizvisa Jan 28, 2019
fdaf88b
Bah! Forgot to call `.format()` after changing the formatstrings in `…
arizvisa Jan 28, 2019
4f34d91
Umm..Wow. Apparently usage of {!r} is considered bad form. Replaced t…
arizvisa Jan 28, 2019
57c3b8c
Re-organized the event_return() implementation in the etcd returner a…
arizvisa Feb 5, 2019
a8ebaeb
Changed the format of the exceptions being aggregated in the event_re…
arizvisa Feb 5, 2019
8ef8ce4
Removed the usage of the ttl from the etcd returner because the optio…
arizvisa Feb 6, 2019
a90c0d3
Apparently it looks like a returner is supposed to generate a new jid…
arizvisa Feb 24, 2019
b585cb2
Added support for purging old jobs by using a lock key to mark jobs t…
arizvisa Feb 24, 2019
8daf223
Moved the ttl calculation in salt.returns.etcd_return under the _get_…
arizvisa Feb 24, 2019
259c528
Added usage of the ttl to remove a job id from the minion job cache u…
arizvisa Feb 24, 2019
f6e56b5
Added an event cache to salt.returners.etcd_return.event_return for k…
arizvisa Feb 24, 2019
ad4fcbd
Removed some trailing whitespace from salt.returners.etcd_return.
arizvisa Feb 24, 2019
196766e
Changed all the exceptions in salt.returners.etcd_return so that the …
arizvisa Feb 24, 2019
3e23e22
Added an implementation of _purge_events() to salt.returners.etcd_ret…
arizvisa Feb 24, 2019
33ddbda
Added a ton more trace logs to salt.returners.etcd_return to enable v…
arizvisa Feb 24, 2019
7bbd215
Renamed the .get and .put apis used by salt.returners.etcd_return to …
arizvisa Feb 25, 2019
056429d
Changed some of the logging in salt.returners.etcd_return.clean_old_j…
arizvisa Feb 25, 2019
6c9858d
Fixed a missing parameter (ttl) when logging with a formatspec in sal…
arizvisa Feb 25, 2019
0fc0c3b
Modified a ton of the format strings in the salt.retuerns.etcd_return…
arizvisa Feb 25, 2019
c449f91
Fixed a type-o in salt.returners.etcd_return that resulted in calling…
arizvisa Feb 25, 2019
b17808c
Modified all of the paths in salt.returners.etcd_return to use a glob…
arizvisa Feb 25, 2019
b895ad1
Fixed some lint issues in the salt.returners.etcd_return module.
arizvisa Feb 25, 2019
6a8548b
Removed the atomic-compare-and-delete call to client.delete in salt.r…
arizvisa Feb 25, 2019
c712470
Fixed salt.returners.etcd_return to prefix the tag that is written in…
arizvisa Feb 25, 2019
97f4da1
Missed a right-bracket when building the tag path in salt.returners.e…
arizvisa Feb 25, 2019
4668a18
Ugh...copy and paste fail in a formatspec in salt.returners.etcd_retu…
arizvisa Feb 25, 2019
c1f48d9
Renamed all the format variables in salt.returners.etcd_return that r…
arizvisa Feb 25, 2019
800e8f3
Revert "Fixed salt.returners.etcd_return to prefix the tag that is wr…
arizvisa Feb 25, 2019
34258d0
Removed an atomic-compare-and-swap in salt.returners.etcd_return.even…
arizvisa Feb 25, 2019
4edec0a
Changed the order in salt.returners.etcd_return that events are purge…
arizvisa Feb 25, 2019
c96037c
Added an implementation of get_jids_filter to salt.returners.etcd_ret…
arizvisa Feb 25, 2019
7baedf8
Inverted some of the functions in the salt.returners.etcd_return modu…
arizvisa Feb 25, 2019
efb3e73
Reverted to the original logic in salt.returners.etcd_return of using…
arizvisa Feb 25, 2019
720a982
Added another key to the event cache for the salt.returners.etcd_retu…
arizvisa Feb 25, 2019
defa0d7
Updated the purge_events function in salt.returners.etcd_return to us…
arizvisa Feb 25, 2019
8b2bb51
Cleaned up some of the comments in salt.returners.etcd_return so that…
arizvisa Feb 25, 2019
d2e82cd
Added some better comments and logging to salt.returners.etcd_return.…
arizvisa Feb 25, 2019
14924c1
Added some missing parentheses in the logging for salt.returners.etcd…
arizvisa Feb 25, 2019
7072886
Renamed variables and logs in salt.returners.etcd_return some more so…
arizvisa Feb 25, 2019
5f20e20
Changed the logic in salt.returners.etcd_return from the original imp…
arizvisa Feb 25, 2019
d104d34
Lol! I didn't realize how fucking busted the original salt.returners.…
arizvisa Feb 25, 2019
7ebcf37
Fixed an exception handler using the wrong variable when logging an e…
arizvisa Feb 25, 2019
f10300d
Umm.. added an import of salt.ext.six.moves.range to salt.returners.e…
arizvisa Feb 25, 2019
c13d427
Removed the 'req' jid hack from the salt.returners.etcd_return module…
arizvisa Feb 26, 2019
6c6bfa5
Updated salt.returners.etcd_return to rename some of the formatspec v…
arizvisa Feb 26, 2019
4487dd3
Renamed the id key in salt.returners.etcd_return to index since it co…
arizvisa Feb 26, 2019
6d42105
Renamed the id template variable used in salt.returners.etcd_return.e…
arizvisa Feb 26, 2019
e4a6468
Renamed the id template variable and event key used in salt.returners…
arizvisa Feb 26, 2019
4f1512f
Updated the package that is written by salt.returners.etcd_return.eve…
arizvisa Feb 26, 2019
7cf78a7
Renamed all instances of event-path to package-path since it's actual…
arizvisa Feb 26, 2019
14f284d
Renamed some of the logs and documentation in salt.returners.etcd_ret…
arizvisa Feb 26, 2019
05aca36
Updated the documentation for salt.returners.etcd_return to explain t…
arizvisa Feb 26, 2019
9fdcae0
Added a missing parentheses when adding the minion id to a package in…
arizvisa Feb 26, 2019
6ac9413
Modified salt.etcd_return.returner to update the job load data instea…
arizvisa Feb 26, 2019
3d4f4f6
Fixed the save_minions function so that it supports usage of a syndic.
arizvisa Feb 26, 2019
3fbd230
Fixed a type-o when loging an update in event_return of the salt.retu…
arizvisa Feb 26, 2019
40e5077
Fixed another type-o in returner of the salt.returners.etcd_return mo…
arizvisa Feb 26, 2019
eeaff90
Demoted some of the warnings in salt.returners.etcd_return when a req…
arizvisa Feb 26, 2019
9033e62
Fixed a mis-cast when building the event-cache path in event_return f…
arizvisa Feb 27, 2019
4a53167
Fixed a logging issue in salt.returners.etcd_return that manifested i…
arizvisa Feb 27, 2019
81154c7
Ugh..Fixed a bunk commit that resulted in an incorrect type being use…
arizvisa Feb 27, 2019
de822d8
Silenced a log when the salt.returners.etcd_returner module calls sav…
arizvisa Feb 27, 2019
b20739a
Changed the comparison in the previous commit that silenced a log in …
arizvisa Feb 27, 2019
b633b0e
As per the conversation at saltstack/stack#51809, all returners need …
arizvisa Feb 27, 2019
4fcbea8
Fixed an incorrect format specifier being used in a log when the salt…
arizvisa Feb 28, 2019
13966b6
Fixed some lint issues in salt.returners.etcd_return.
arizvisa Mar 8, 2019
8211656
Merge branch 'develop' into etcd-returner-is-busted
Akm0d Jun 14, 2019
17f20ee
Merge branch 'develop' into etcd-returner-is-busted
Akm0d Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading