Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various typos #51594

Closed
wants to merge 44 commits into from
Closed

Fix various typos #51594

wants to merge 44 commits into from

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Feb 12, 2019

Lintian found various spelling mistakes in salt. This pull requests fixes all of them (in individual commits to make the review easier).

@bdrung bdrung requested a review from a team as a code owner February 12, 2019 10:46
terminalmage
terminalmage approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@terminalmage terminalmage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that the release notes changelogs are automatically generated using git commit history.

@bdrung bdrung force-pushed the fix-typos branch 3 times, most recently from 070a2a5 to 93776b1 Compare February 13, 2019 10:06
@dwoz dwoz force-pushed the fix-typos branch 2 times, most recently from 4a147b7 to 9b49c7f Compare February 23, 2019 21:35
@dwoz
Copy link
Contributor

dwoz commented Feb 23, 2019

@bdrung I've rebased this on top of 2018.3 and reverted the changes to the change logs. Since the change logs are automatically generated from commit messages, we don't want to fix these typos. Thanks again for the great work here!

@bdrung bdrung force-pushed the fix-typos branch 2 times, most recently from 7edb183 to a1cbecc Compare April 25, 2019 10:18
@bdrung bdrung force-pushed the fix-typos branch 2 times, most recently from 9cfaf19 to e6bcbad Compare May 14, 2019 11:19
@bdrung
Copy link
Contributor Author

bdrung commented Feb 21, 2020

Obsoleted by pull request #55954 against the master branch.

@bdrung bdrung closed this Feb 21, 2020
@bdrung bdrung deleted the fix-typos branch February 21, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@terminalmage terminalmage terminalmage approved these changes

Assignees
No one assigned
Labels
Reviewers-Assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdrung @dwoz @waynew @terminalmage @Ch3LL