-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salt cloud map alt update #51749
Salt cloud map alt update #51749
Conversation
Hey, thanks for the PR! I'm not positive, but I think these build failures might be something on our Jenkins server. We've got someone looking into it! |
Sounds good, if I am doing something wrong please clarify! It's taken me three weeks to figure out all the requirements for doing salt doc changes. So I wouldn't be surprised if I am still doing it wrong. |
No worries - I know that if you're not familiar with the tools it can be a bit daunting :) There's nothing that sticks out to me as obviously wrong from your PR, and nothing about your PR that Jenkins is obviously complaining about, which is why I'm guessing that there's something going odd with our Jenkins. But I want to make sure that I'm not missing something before we approve this! |
has anything come up to explain the check failures? |
@alan-cugler are you okay migrating this PR to the 2018.3 branch since that branch is now the previous docs branch? |
@Ch3LL I switched it over, let me know if I did it wrong. |
This should be able to PR in now. |
…guration options. This is a result of @Ch3LL suggestion on the PR itself for this doc change.
9382c65
to
9ca0f72
Compare
@Ch3LL I made the change, after jenkins testing it should be good for merge. |
What does this PR do?
links the map file page to the salt cloud file page, and clarifies briefly that options listed in the salt-cloud page can also be put in the cloud map files.
What issues does this PR fix or reference?
Fixes #51127
Commits signed with GPG?
Yes