-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add engine for fluent #51942
Add engine for fluent #51942
Conversation
@mchugh19 Looks like there are some lint failures and a merge conflict. |
This reverts commit c6b4690.
Fixed the junky commit. Should be lint clean now. |
@mchugh19 Hey, thanks for the PR! Could we get some tests for this? |
Having a bit of trouble here. The other engine test examples are the sqs engine which validates sqs messages can be resent on the salt event bus, while the slack tests validate the complex configuration. For the fluent engine, it really is just:
where I'm struggling to come up with a meaningful test. As long as the fluent event module is functional, and the event_bus.get_event_block() works as expected, there isn't much else to validate here. Thoughts? |
@mchugh19 Looks like we have some lint failures here.
|
github editor created lint issue fixed :) |
Bump. I think this is all set |
Can this make it in for Neon? |
Looks like got out of date again... I'm on my phone right now but if I'm reading it correctly it's been approved, so with an update we should be able to get this in... As soon as it's all up to date and passing 😝 |
Well, let's update this again 😛 We've also been having some struggles with our CI hitting the GitHub rate limits (good growing pains??) but I think we've got that sorted. I'll keep an eye on this throughout the day for the builds to finish 🤞 |
@mchugh19 can you rebase this PR to master and update the base branch please? |
Closing this out for the master branch based #55711 |
What does this PR do?
Adds new engine to export events to fluentd
What issues does this PR fix or reference?
None
Tests written?
No
Commits signed with GPG?
No