Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engine for fluent #51942

Closed
wants to merge 28 commits into from
Closed

Add engine for fluent #51942

wants to merge 28 commits into from

Conversation

mchugh19
Copy link
Contributor

@mchugh19 mchugh19 commented Mar 2, 2019

What does this PR do?

Adds new engine to export events to fluentd

What issues does this PR fix or reference?

None

Tests written?

No

Commits signed with GPG?

No

@garethgreenaway
Copy link
Contributor

@mchugh19 Looks like there are some lint failures and a merge conflict.

@mchugh19 mchugh19 requested a review from a team as a code owner March 16, 2019 09:11
@mchugh19
Copy link
Contributor Author

Fixed the junky commit. Should be lint clean now.

salt/engines/fluent.py Show resolved Hide resolved
@twangboy
Copy link
Contributor

@mchugh19 Hey, thanks for the PR! Could we get some tests for this?

@mchugh19
Copy link
Contributor Author

Could we get some tests for this?

Having a bit of trouble here. The other engine test examples are the sqs engine which validates sqs messages can be resent on the salt event bus, while the slack tests validate the complex configuration. For the fluent engine, it really is just:

while True:
    salt_event = event_bus.get_event_block()
    if salt_event:
        event.Event(app, salt_event)

sender.close()

where I'm struggling to come up with a meaningful test. As long as the fluent event module is functional, and the event_bus.get_event_block() works as expected, there isn't much else to validate here.

Thoughts?

salt/engines/fluent.py Outdated Show resolved Hide resolved
@twangboy
Copy link
Contributor

@mchugh19 Looks like we have some lint failures here.

fluent.py:95, PyLint, Priority: Low
--
Trailing whitespace

@mchugh19
Copy link
Contributor Author

github editor created lint issue fixed :)

@mchugh19
Copy link
Contributor Author

mchugh19 commented May 1, 2019

Bump. I think this is all set

@mchugh19
Copy link
Contributor Author

mchugh19 commented Jun 1, 2019

Can this make it in for Neon?

@waynew
Copy link
Contributor

waynew commented Jun 1, 2019

Looks like got out of date again... I'm on my phone right now but if I'm reading it correctly it's been approved, so with an update we should be able to get this in... As soon as it's all up to date and passing 😝

@waynew
Copy link
Contributor

waynew commented Jun 5, 2019

Well, let's update this again 😛

We've also been having some struggles with our CI hitting the GitHub rate limits (good growing pains??) but I think we've got that sorted. I'll keep an eye on this throughout the day for the builds to finish 🤞

@mchugh19 mchugh19 changed the base branch from develop to neon November 17, 2019 18:10
@dwoz
Copy link
Contributor

dwoz commented Dec 19, 2019

@mchugh19 can you rebase this PR to master and update the base branch please?

@mchugh19 mchugh19 changed the base branch from neon to master December 20, 2019 07:21
@mchugh19 mchugh19 changed the base branch from master to neon December 20, 2019 07:22
@mchugh19
Copy link
Contributor Author

Closing this out for the master branch based #55711

@mchugh19 mchugh19 closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants