Use uncommon item in mine delete test #52393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using `grains.items`, `test.arg` is less common, and specifiying a value that isn't currently used anywhere else should eliminate any chance of race condition for this test.
dwoz
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As an attempt to prevent #52087 from failing during a (probable) race condition, rather than using
grains.items, I've refactored this test to usetest.argwhich is less common, andspecifying a value that isn't currently used anywhere else.
What issues does this PR fix or reference?
#52087
Previous Behavior
If a
mine.send \* grains.itemswas launched, or for any other reason the mine was updated with grains betweenmine.deleteandmine.get, this test would fail due to the race condition (see #52087)New Behavior
Use
test.argwith an unlikely value in an attempt to avoid any possibility of race conditionTests written?
Yes (and, since this was changing the test, I also manually verified - failing to actually delete the the value in the mine makes the test fail).
Commits signed with GPG?
Yes