-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for jid before returning data #52459
Conversation
Seems raw can have returns for the same minion, but an other job. In order to not return resutls from the wrong job, we need to check for the jid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a test for this change?
@Ch3LL Sorry for dragging my feet here for so long, but finally I've just added two test cases. Could you please check your the test runs? Hudson seems to have problems fetching the changes. |
I restarted the tests. I went ahead and tested this PR against my test case i pasted in the issue and unfortunately im still seeing the issue:
are you seeing it fixed for you? I tried multiple times to make sure. |
@Ch3LL I've been re-running the tests several times and for me the issue is gone. As soon as I remove the patch, I see it again. Are you running both scripts on the master? |
What does this PR do?
Seems raw can have returns for the same minion, but an other job. In order to not return resutls from the wrong job, we need to check for the jid.
What issues does this PR fix or reference?
#50927
Previous Behavior
Wrong job results might be returned. Please take a look at #50927
New Behavior
Only the correct jobs results should be returned.
Tests written?
No
Commits signed with GPG?
Yes