Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly close IPC connections #52495

Merged
merged 20 commits into from
Apr 16, 2019
Merged

Explicitly close IPC connections #52495

merged 20 commits into from
Apr 16, 2019

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Apr 11, 2019

What does this PR do?

  • Makes salt event context aware
  • Use context manages for events when possible
  • When not using context mangers for event, make sure we call destroy method on event instances.

Tests written?

No - Fixing existing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from a team as a code owner April 11, 2019 01:29
@dwoz dwoz changed the title [WIP] Explicitly close IPC connections Explicitly close IPC connections Apr 11, 2019
@waynew
Copy link
Contributor

waynew commented Apr 15, 2019

👍 I'm certainly a fan

@s0undt3ch s0undt3ch merged commit 8830bd8 into saltstack:2018.3 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew left review comments

@Ch3LL Ch3LL Ch3LL approved these changes

@DmitryKuzmenko DmitryKuzmenko DmitryKuzmenko approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwoz @waynew @s0undt3ch @DmitryKuzmenko @Ch3LL