Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2] Marking the two tests in test_gce as flaky #52551

Merged

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Marking the two tests in test_gce as flaky.

What issues does this PR fix or reference?

#52449

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team April 15, 2019 16:24
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per some Slack discussion, this is either because:

a) AWS and GCE are playing silly beggars
b) apache-libcloud is failing to do the right thing Re: GCE
c) A race condition (that probably wouldn't be worth working around)
d) Something else
e) All of the above :trollface:

@dwoz dwoz merged commit b173406 into saltstack:2019.2 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants