fix: #51842 #52553
Merged
fix: #51842 #52553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
reviewed
Apr 15, 2019
| minion_fn = models.CharField() | ||
| user_fk = models.ForeignKey(User, on_delete=models.CASCADE) | ||
| minion_or_fn_matcher = models.CharField(max_length=255) | ||
| minion_fn = models.CharField(max_length=255) |
There was a problem hiding this comment.
If there's an assumption of Postgres as the database, there's no reason to add max_length.
There was a problem hiding this comment.
Ah... I see it's required in Django's CharField
There was a problem hiding this comment.
Apparently one needs to make their own CharField to avoid Django's limit
waynew
approved these changes
Apr 15, 2019
|
It's a documentation change...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #51842 Wrong model name
What issues does this PR fix or reference?
#51842