[2018.3] Fixes to multiprocessing queue when using MacOS #52754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… running on MacOS then we use that maximum.
s0undt3ch
approved these changes
Apr 30, 2019
waynew
added
the
bugfix-bckport
|
@garethgreenaway not 100% sure if we should backport this to 2017.7 for that final release, but currently it looks like this is what's preventing that branch from building. 2018.3 is running into some other issues that I'm looking into. |
|
We should also bring this to 2019.2.1? |
This was referenced May 16, 2019
Ch3LL
added
ZZZ[Done]-back-ported-bf
twangboy
added a commit
that referenced
this pull request
May 16, 2019
Backport #52754 into 2019.2.1
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The maximum for the multiprocessing queue on MacOS is 32767, so if we running on MacOS then we use that maximum.
What issues does this PR fix or reference?
N/A
Previous Behavior
Tests do not run currently on MacOS
New Behavior
Allows tests to run
Tests written?
No. Fixes to existing tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.