Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging fix for cmdmod._run #53455

Conversation

DmitryKuzmenko
Copy link
Contributor

What does this PR do?

This was detected when tests failed because of memory allocation errors.
In this case cmdmod reports "command not found" as an error reason when the original OSError says "cannot allocate memory".

What issues does this PR fix or reference?

Related to #53281

Previous Behavior

Error message on memory allocation failure looks like this:

Unable to run command '[u'grep', u'-lr', u'salt.utils.versions.warn_until', u'-A', u'1', u'/tmp/kitchen/testing/salt/']' with the context <CUT>, reason: command not found

New Behavior

Error message on memory allocation failure looks like this:

Unable to run command '[u'grep', u'-lr', u'salt.utils.versions.warn_until', u'-A', u'1', u'/tmp/kitchen/testing/salt/']' with the context <CUT>, reason: [Errno 12] Cannot allocate memory

Tests written?

Minor logging fix, tested manually.

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow self-requested a review June 14, 2019 18:57
@DmitryKuzmenko
Copy link
Contributor Author

Duplicates #49490

@DmitryKuzmenko DmitryKuzmenko deleted the bugs/cmdmod_logging_fix branch October 23, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants