Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port from 2018.3 Add event_listen_queue_max_seconds to fix #53411 #53587

Merged
merged 6 commits into from
Jun 28, 2019

Conversation

cro
Copy link
Contributor

@cro cro commented Jun 24, 2019

What does this PR do?

Forward ports PR #53412 from 2018.3 to fix #53411

What issues does this PR fix or reference?

#53411

@cro cro requested a review from a team as a code owner June 24, 2019 22:08
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #53587 into 2019.2.1 will increase coverage by 23.54%.
The diff coverage is 16.12%.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53587       +/-   ##
=============================================
+ Coverage     13.51%   37.06%   +23.54%     
=============================================
  Files          1520     1576       +56     
  Lines        252497   269579    +17082     
  Branches      53843    57490     +3647     
=============================================
+ Hits          34125    99911    +65786     
+ Misses       215553   158429    -57124     
- Partials       2819    11239     +8420
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.67% <16.12%> (?)
#debian9 36.45% <16.12%> (?)
#proxy ?
#py2 36.84% <16.12%> (+23.46%) ⬆️
#py3 36.05% <16.12%> (+24.83%) ⬆️
#ubuntu1604 36.8% <16.12%> (+31.8%) ⬆️
Impacted Files Coverage Δ
salt/config/__init__.py 62.74% <ø> (ø)
salt/utils/event.py 56.85% <16.12%> (+21.38%) ⬆️
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/utils/smb.py 19.83% <0%> (-38.87%) ⬇️
... and 1176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b7fc4...d74c313. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #53587 into 2019.2.1 will increase coverage by 23.54%.
The diff coverage is 16.12%.

Impacted file tree graph

@@              Coverage Diff              @@
##           2019.2.1   #53587       +/-   ##
=============================================
+ Coverage     13.51%   37.06%   +23.54%     
=============================================
  Files          1520     1576       +56     
  Lines        252497   269579    +17082     
  Branches      53843    57490     +3647     
=============================================
+ Hits          34125    99911    +65786     
+ Misses       215553   158429    -57124     
- Partials       2819    11239     +8420
Flag Coverage Δ
#arch ?
#centos7 ?
#debian8 36.67% <16.12%> (?)
#debian9 36.45% <16.12%> (?)
#proxy ?
#py2 36.84% <16.12%> (+23.46%) ⬆️
#py3 36.05% <16.12%> (+24.83%) ⬆️
#ubuntu1604 36.8% <16.12%> (+31.8%) ⬆️
Impacted Files Coverage Δ
salt/config/__init__.py 62.74% <ø> (ø)
salt/utils/event.py 56.85% <16.12%> (+21.38%) ⬆️
salt/proxy/dummy.py 0% <0%> (-80.87%) ⬇️
salt/proxy/docker.py 0% <0%> (-62.5%) ⬇️
salt/proxy/chronos.py 0% <0%> (-50%) ⬇️
salt/proxy/marathon.py 0% <0%> (-50%) ⬇️
salt/proxy/cisconso.py 0% <0%> (-46.43%) ⬇️
salt/proxy/arista_pyeapi.py 0% <0%> (-45.66%) ⬇️
salt/proxy/nxos_api.py 0% <0%> (-44.74%) ⬇️
salt/utils/smb.py 19.83% <0%> (-38.87%) ⬇️
... and 1176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b7fc4...d74c313. Read the comment docs.

Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/o tests per Tom's exception here: #53412 (review)

@cro
Copy link
Contributor Author

cro commented Jun 25, 2019

re-run full all

@cro cro merged commit 6559e4c into saltstack:2019.2.1 Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants