Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #53035 to master #54567

Closed
wants to merge 8 commits into from
Closed

[master] Porting #53035 to master #54567

wants to merge 8 commits into from

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 18, 2019 •
edited
Loading

Porting #53035 to master

@garethgreenaway garethgreenaway requested a review from a team September 18, 2019 23:56
@ghost ghost requested review from Akm0d and removed request for a team September 18, 2019 23:56
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #53035 to 2019.2.1 [master] Porting #53035 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:54
dwoz
dwoz requested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmcmarrow Can we add a docs reference to this as was originally requested on #53035?

@dwoz
Copy link
Contributor

dwoz commented Oct 24, 2019

re-run full all

@Ch3LL
Copy link
Contributor

Ch3LL commented Oct 24, 2019

will need to add a reference in this file: doc/ref/states/all/index.rst
as well as add new file here doc/ref/states/all/salt.states.win_task.rst

salt.states.win_task module
===========================

.. automodule:: salt.states.win_task
    :members:
    :undoc-members:

s0undt3ch
s0undt3ch suggested changes Oct 28, 2019
View reviewed changes
salt/states/win_task.py Outdated Show resolved Hide resolved
tests/unit/states/test_win_task.py Outdated Show resolved Hide resolved
@garethgreenaway garethgreenaway requested a review from a team as a code owner November 15, 2019 18:20
@cmcmarrow cmcmarrow requested review from s0undt3ch and dwoz November 15, 2019 21:19
Akm0d
Akm0d previously approved these changes Nov 15, 2019
View reviewed changes
xeacott
xeacott previously approved these changes Nov 15, 2019
View reviewed changes
s0undt3ch
s0undt3ch previously approved these changes Nov 16, 2019
View reviewed changes
salt/states/win_task.py Outdated Show resolved Hide resolved
@dwoz
Copy link
Contributor

dwoz commented Apr 13, 2020

These test failures need to get looked at.

@dwoz dwoz dismissed stale reviews from s0undt3ch, xeacott, and Akm0d via 47bfd39 April 20, 2020 01:47
@dwoz
Copy link
Contributor

dwoz commented Dec 10, 2023

Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle.

@dwoz dwoz closed this Dec 10, 2023
@dwoz dwoz added help-wanted Community help is needed to resolve this Abandoned labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeacott xeacott xeacott left review comments

@Akm0d Akm0d Akm0d left review comments

@s0undt3ch s0undt3ch s0undt3ch left review comments

@dwoz dwoz Awaiting requested review from dwoz

Assignees

@garethgreenaway garethgreenaway

Labels
Abandoned has-failing-test help-wanted Community help is needed to resolve this master-port
Projects
PRs to port to master
Status: PR merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@garethgreenaway @dwoz @Ch3LL @s0undt3ch @Akm0d @xeacott @sagetherage