Fix to scheduler when job without a time element is run with schedule.run_job #54799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning that job with schedule.run_job fails with a traceback because data['run'] does not exist.
garethgreenaway
changed the title
…Updating unit/test_module_names.py to include integration.scheduler.test_run_job.
dwoz
approved these changes
Sep 29, 2019
dhiltonp
reviewed
Sep 29, 2019
dhiltonp
suggested changes
Sep 29, 2019
dhiltonp
reviewed
Sep 29, 2019
…:garethgreenaway/salt into 54741_run_job_fails_without_time_element
dhiltonp
approved these changes
Sep 29, 2019
twangboy
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If a scheduled job does not contains a time element parameter, running that job with schedule.run_job fails and causes a traceback because data['run'] does not exist.
What issues does this PR fix or reference?
#54741
Previous Behavior
Jobs without time elements when run with "schedule.run_job" failed with traceback.
New Behavior
Ensure data['run'] exists and handle situations when it does not. Jobs run as expected.
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.