keep cache_copied_files variable a list #56327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Minor fix with no change in functionality. Would be nice to get into a backport. |
garethgreenaway
added
the
Needs-Testcase
|
@mchugh19 Thanks for the fix. Would be great to get a testcase on this one to prevent regressions. |
|
@garethgreenaway tests added! Looks like the issue can be replicated with includes. I've validated the issue is present with the saltcheck integration test without the fix, and corrected with the patch. This should be good to go! |
|
@Ch3LL it'd be nice if this could make 3000.1 |
|
let me update the branch, and have the tests run and see about getting it in. i'll let ya know |
s0undt3ch
approved these changes
Mar 12, 2020
twangboy
approved these changes
Mar 13, 2020
cmcmarrow
approved these changes
Mar 13, 2020
Ch3LL
added
v3000.1
Ch3LL
approved these changes
Mar 13, 2020
|
@mchugh19 been merged and will be included in 3000.1. thanks for the headsup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Retains list datatype of cache_copied_files variable
What issues does this PR fix or reference?
#56324
Previous Behavior
Capable of runtime error
AttributeError: 'set' object has no attribute 'extend'New Behavior
Datatype of cache_copied_files is consistently a list
Tests written?
Yes
Commits signed with GPG?
No