Allow setting boot device order in virt.running and virt.defined #57545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
rebased on master |
xeacott
previously approved these changes
Jun 5, 2020
This was referenced Jun 8, 2020
|
Updated on latest master |
boot_dev parameter was hidden for a long time in the virt.init() function but so nicely hidden that it never bubbled in the virt.update() parameters. This commit is just reparing this mistake.
virt.init knows how to set the boot device order for a while, but this feature never came to virt.running. This commit is fixing this omission and adds it for both virt.running and virt.defined states.
|
rebased on master |
Akm0d
approved these changes
Jul 31, 2020
s0undt3ch
approved these changes
Jul 31, 2020
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Oct 20, 2020
* Fix various spelling mistakes in master branch (saltstack#55954) * Fix typo of additional Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of against Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of amount Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of argument Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attempt Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of bandwidth Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of caught Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of compatibility Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of consistency Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of conversions Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of corresponding Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dependent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dictionary Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disabled Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of adapters Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disassociates Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of changes Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of command Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of communicate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of community Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of configuration Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of default Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of absence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attribute Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of container Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of described Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of existence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of explicit Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of formatted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of guarantees Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hexadecimal Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hierarchy Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of initialize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of label Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of management Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of mismatch Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of don't Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of manually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of getting Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of information Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of meant Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of nonexistent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of occur Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of omitted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of normally Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of overridden Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of repository Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separator Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of specific Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of successful Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of succeeded Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of support Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of version Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of that's Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of "will be removed" Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of release Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of synchronize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of python Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of usually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of override Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of running Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of whether Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of package Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of persist Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of preferred Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of present Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of run Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "allows someone to..." "Allows to" is not correct English. It must either be "allows someone to" or "allows doing". Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "number of times" Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of msgpack Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemonized Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemons Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of extemporaneous Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of instead Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of returning Signed-off-by: Benjamin Drung <[email protected]> * Fix literal comparissons * virt: Convert cpu_baseline ElementTree to string In commit 0f5184c (Remove minidom use in virt module) the value of `cpu` become `xml.etree.ElementTree.Element` and no longer has a method `toxml()`. This results in the following error: $ salt '*' virt.cpu_baseline host2: The minion function caused an exception: Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/salt/minion.py", line 1675, in _thread_return return_data = minion_instance.executors[fname](opts, data, func, args, kwargs) File "/usr/lib/python3.7/site-packages/salt/executors/direct_call.py", line 12, in execute return func(*args, **kwargs) File "/usr/lib/python3.7/site-packages/salt/modules/virt.py", line 4410, in cpu_baseline return cpu.toxml() AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'toxml' Signed-off-by: Radostin Stoyanov <[email protected]> * PR#57374 backport virt: pool secret should be undefined in pool_undefine not pool_delete virt: handle build differently depending on the pool type virt: don't fail if the pool secret has been removed * PR saltstack#57396 backport add firmware auto select feature * virt: Update dependencies Closes: saltstack#57641 Signed-off-by: Radostin Stoyanov <[email protected]> * use null in sls file to map None object add sls file example reword doc * Update virt module and states and their tests to python3 * PR saltstack#57545 backport Move virt.init boot_dev parameter away from the kwargs virt: handle boot device in virt.update() virt: add boot_dev parameter to virt.running state * PR saltstack#57431 backport virt: Handle no available hypervisors virt: Remove unused imports * Blacken salt * Add method to remove circular references in data objects and add test (saltstack#54930) * Add method to remove circular references in data objects and add test * remove trailing whitespace * Blacken changed files Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]> * PR saltstack#58332 backport virt: add debug log with VM XML definition Add xmlutil.get_xml_node() helper function Add salt.utils.data.get_value function Add change_xml() function to xmlutil virt.update: refactor the XML diffing code virt.test_update: move some code to make test more readable Co-authored-by: Benjamin Drung <[email protected]> Co-authored-by: Pedro Algarvio <[email protected]> Co-authored-by: Radostin Stoyanov <[email protected]> Co-authored-by: Firefly <[email protected]> Co-authored-by: Blacken Salt <[email protected]> Co-authored-by: Joe Eacott <[email protected]> Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]>
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Apr 13, 2021
* Fix various spelling mistakes in master branch (saltstack#55954) * Fix typo of additional Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of against Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of amount Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of argument Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attempt Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of bandwidth Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of caught Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of compatibility Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of consistency Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of conversions Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of corresponding Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dependent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dictionary Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disabled Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of adapters Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disassociates Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of changes Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of command Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of communicate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of community Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of configuration Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of default Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of absence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attribute Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of container Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of described Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of existence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of explicit Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of formatted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of guarantees Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hexadecimal Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hierarchy Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of initialize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of label Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of management Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of mismatch Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of don't Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of manually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of getting Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of information Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of meant Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of nonexistent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of occur Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of omitted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of normally Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of overridden Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of repository Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separator Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of specific Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of successful Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of succeeded Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of support Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of version Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of that's Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of "will be removed" Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of release Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of synchronize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of python Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of usually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of override Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of running Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of whether Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of package Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of persist Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of preferred Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of present Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of run Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "allows someone to..." "Allows to" is not correct English. It must either be "allows someone to" or "allows doing". Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "number of times" Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of msgpack Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemonized Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemons Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of extemporaneous Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of instead Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of returning Signed-off-by: Benjamin Drung <[email protected]> * Fix literal comparissons * virt: Convert cpu_baseline ElementTree to string In commit 0f5184c (Remove minidom use in virt module) the value of `cpu` become `xml.etree.ElementTree.Element` and no longer has a method `toxml()`. This results in the following error: $ salt '*' virt.cpu_baseline host2: The minion function caused an exception: Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/salt/minion.py", line 1675, in _thread_return return_data = minion_instance.executors[fname](opts, data, func, args, kwargs) File "/usr/lib/python3.7/site-packages/salt/executors/direct_call.py", line 12, in execute return func(*args, **kwargs) File "/usr/lib/python3.7/site-packages/salt/modules/virt.py", line 4410, in cpu_baseline return cpu.toxml() AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'toxml' Signed-off-by: Radostin Stoyanov <[email protected]> * PR#57374 backport virt: pool secret should be undefined in pool_undefine not pool_delete virt: handle build differently depending on the pool type virt: don't fail if the pool secret has been removed * PR saltstack#57396 backport add firmware auto select feature * virt: Update dependencies Closes: saltstack#57641 Signed-off-by: Radostin Stoyanov <[email protected]> * use null in sls file to map None object add sls file example reword doc * Update virt module and states and their tests to python3 * PR saltstack#57545 backport Move virt.init boot_dev parameter away from the kwargs virt: handle boot device in virt.update() virt: add boot_dev parameter to virt.running state * PR saltstack#57431 backport virt: Handle no available hypervisors virt: Remove unused imports * Blacken salt * Add method to remove circular references in data objects and add test (saltstack#54930) * Add method to remove circular references in data objects and add test * remove trailing whitespace * Blacken changed files Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]> * PR saltstack#58332 backport virt: add debug log with VM XML definition Add xmlutil.get_xml_node() helper function Add salt.utils.data.get_value function Add change_xml() function to xmlutil virt.update: refactor the XML diffing code virt.test_update: move some code to make test more readable Co-authored-by: Benjamin Drung <[email protected]> Co-authored-by: Pedro Algarvio <[email protected]> Co-authored-by: Radostin Stoyanov <[email protected]> Co-authored-by: Firefly <[email protected]> Co-authored-by: Blacken Salt <[email protected]> Co-authored-by: Joe Eacott <[email protected]> Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]>
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jun 25, 2021
* Fix various spelling mistakes in master branch (saltstack#55954) * Fix typo of additional Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of against Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of amount Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of argument Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attempt Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of bandwidth Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of caught Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of compatibility Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of consistency Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of conversions Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of corresponding Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dependent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of dictionary Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disabled Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of adapters Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of disassociates Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of changes Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of command Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of communicate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of community Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of configuration Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of default Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of absence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of attribute Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of container Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of described Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of existence Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of explicit Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of formatted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of guarantees Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hexadecimal Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of hierarchy Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of initialize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of label Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of management Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of mismatch Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of don't Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of manually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of getting Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of information Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of meant Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of nonexistent Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of occur Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of omitted Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of normally Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of overridden Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of repository Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separate Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of separator Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of specific Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of successful Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of succeeded Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of support Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of version Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of that's Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of "will be removed" Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of release Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of synchronize Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of python Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of usually Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of override Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of running Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of whether Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of package Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of persist Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of preferred Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of present Signed-off-by: Benjamin Drung <[email protected]> * Fix typo of run Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "allows someone to..." "Allows to" is not correct English. It must either be "allows someone to" or "allows doing". Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of "number of times" Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of msgpack Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemonized Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of daemons Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of extemporaneous Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of instead Signed-off-by: Benjamin Drung <[email protected]> * Fix spelling mistake of returning Signed-off-by: Benjamin Drung <[email protected]> * Fix literal comparissons * virt: Convert cpu_baseline ElementTree to string In commit 0f5184c (Remove minidom use in virt module) the value of `cpu` become `xml.etree.ElementTree.Element` and no longer has a method `toxml()`. This results in the following error: $ salt '*' virt.cpu_baseline host2: The minion function caused an exception: Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/salt/minion.py", line 1675, in _thread_return return_data = minion_instance.executors[fname](opts, data, func, args, kwargs) File "/usr/lib/python3.7/site-packages/salt/executors/direct_call.py", line 12, in execute return func(*args, **kwargs) File "/usr/lib/python3.7/site-packages/salt/modules/virt.py", line 4410, in cpu_baseline return cpu.toxml() AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'toxml' Signed-off-by: Radostin Stoyanov <[email protected]> * PR#57374 backport virt: pool secret should be undefined in pool_undefine not pool_delete virt: handle build differently depending on the pool type virt: don't fail if the pool secret has been removed * PR saltstack#57396 backport add firmware auto select feature * virt: Update dependencies Closes: saltstack#57641 Signed-off-by: Radostin Stoyanov <[email protected]> * use null in sls file to map None object add sls file example reword doc * Update virt module and states and their tests to python3 * PR saltstack#57545 backport Move virt.init boot_dev parameter away from the kwargs virt: handle boot device in virt.update() virt: add boot_dev parameter to virt.running state * PR saltstack#57431 backport virt: Handle no available hypervisors virt: Remove unused imports * Blacken salt * Add method to remove circular references in data objects and add test (saltstack#54930) * Add method to remove circular references in data objects and add test * remove trailing whitespace * Blacken changed files Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]> * PR saltstack#58332 backport virt: add debug log with VM XML definition Add xmlutil.get_xml_node() helper function Add salt.utils.data.get_value function Add change_xml() function to xmlutil virt.update: refactor the XML diffing code virt.test_update: move some code to make test more readable Co-authored-by: Benjamin Drung <[email protected]> Co-authored-by: Pedro Algarvio <[email protected]> Co-authored-by: Radostin Stoyanov <[email protected]> Co-authored-by: Firefly <[email protected]> Co-authored-by: Blacken Salt <[email protected]> Co-authored-by: Joe Eacott <[email protected]> Co-authored-by: xeacott <[email protected]> Co-authored-by: Frode Gundersen <[email protected]> Co-authored-by: Daniel A. Wozniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes the
virt.init()boot_devparameter in thevirt.runningandvirt.definedstates.What issues does this PR fix or reference?
Fixes: #57544
Merge requirements satisfied?
Commits signed with GPG?
Yes