Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virt update when cpu and memory are changed #58465

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Fix virt update when cpu and memory are changed #58465

merged 1 commit into from
Sep 25, 2020

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Sep 15, 2020

What does this PR do?

If both CPU and memory are changed, the memory change would be short circuited since the need_update would be set to True before due to the CPU value change.

What issues does this PR fix or reference?

Fixes a regression introduced by PR #58332

Merge requirements satisfied?

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from a team as a code owner September 15, 2020 14:31
@ghost ghost requested review from krionbsd and removed request for a team September 15, 2020 14:32
Akm0d
Akm0d previously approved these changes Sep 15, 2020
View reviewed changes
krionbsd
krionbsd previously approved these changes Sep 15, 2020
View reviewed changes
@cbosdo
Copy link
Contributor Author

cbosdo commented Sep 15, 2020

@dwoz all tests were green, just hit the Update Branch button. Hope you'll be able to merge it before it gets outdated again ;)

@cbosdo
Copy link
Contributor Author

cbosdo commented Sep 16, 2020

@dwoz Would be good to have this PR in for Magnesium before we get a regression released

@cbosdo
Copy link
Contributor Author

cbosdo commented Sep 22, 2020

re-run lint

@sagetherage sagetherage added Magnesium Mg release after Na prior to Al Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. labels Sep 23, 2020
@sagetherage sagetherage added this to the Magnesium milestone Sep 23, 2020
@cbosdo
Fix virt update when cpu and memory are changed
68c751f 
If CPU is changed, the memory change would be short circuited. This is a
regression introduced by PR saltstack#58332
@cbosdo cbosdo dismissed stale reviews from krionbsd and Akm0d via 68c751f September 25, 2020 14:11
@cbosdo
Copy link
Contributor Author

cbosdo commented Sep 25, 2020

@Akm0d @krionbsd could you re-ACK this PR? I had to fix the pre-commit hook again due to the automatic removal of the import comments

@sagetherage sagetherage added the severity-high 2nd top severity, seen by most users, causes major problems label Sep 25, 2020
@dwoz dwoz merged commit 6554e5a into saltstack:master Sep 25, 2020
@cbosdo cbosdo mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akm0d Akm0d Akm0d approved these changes

@krionbsd krionbsd krionbsd approved these changes

Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al Regression The issue is a bug that breaks functionality known to work in previous releases. severity-high 2nd top severity, seen by most users, causes major problems
Projects
None yet
Milestone
Magnesium
Development

Successfully merging this pull request may close these issues.
5 participants
@cbosdo @Akm0d @krionbsd @dwoz @sagetherage