Address leaks in fileserver caused by git backends #60386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krionbsd
previously approved these changes
Jun 17, 2021
|
re-run mac |
sagetherage
added
Silicon v3004.0
s0undt3ch
suggested changes
Jun 20, 2021
At this time we do not have the ability to fix the upstream memory leaks in the gitfs backend providers. Work around their limitations by periodically restarting the file server update proccess. This will at least partially address saltstack#50313
Ch3LL
approved these changes
Jun 23, 2021
|
Sorry for the spamming, but a big THANKS for this! |
|
I believe this should resolve most, if not all of #59360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At this time we do not have the ability to fix the upstream memory leaks
in the gitfs backend providers. Work around their limitations by
periodically restarting the file server update proccess. This will at
least partially address #50313
What issues does this PR fix or reference?
Fixes: #50313
Previous Behavior
File server update process would run indefinitely continuing to leak memory.
New Behavior
File server update process will restart periodically to release held memory.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.