Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push dep neut #60774

Merged
merged 8 commits into from
Aug 24, 2021
Merged

Push dep neut #60774

merged 8 commits into from
Aug 24, 2021

Conversation

cmcmarrow
Copy link
Contributor

What does this PR do?

push neutron deprecation to sulfur.

We need to give people time to move to salt.pillar.neutron -> salt.pillar.neutronng
'salt.pillar.neutronng'

What issues does this PR fix or reference?

Fixes: #55663

Commits signed with GPG?

Yes

@cmcmarrow cmcmarrow requested a review from a team as a code owner August 20, 2021 06:35
@cmcmarrow cmcmarrow requested review from krionbsd and removed request for a team August 20, 2021 06:35
@cmcmarrow
Copy link
Contributor Author

#59871

Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be new line joined?

waynew
waynew previously approved these changes Aug 20, 2021
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we've discussed changing from creating a "ng" module and instead making the new behavior exist side by side with the existing module (perhaps guarded by a temporary flag), so we don't end out with multiple modules like this.

I don't know if we have a solid plan in place for that yet, but...

@Ch3LL Ch3LL merged commit 972166e into saltstack:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate neutron pillar to use neutronng module
5 participants