Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed state return in file state #61815

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Fix malformed state return in file state #61815

merged 3 commits into from
Sep 10, 2022

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Mar 21, 2022 •
edited
Loading

What does this PR do?

Fixes two three instances of malformed state return in file state module.

What issues does this PR fix or reference?

Fixes #55269 + related issue on Windows
Fixes #61814

Previous Behavior

An exception occurred in this state: Malformed state return. Data must be a dictionary type.

New Behavior

Returns proper error description.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lkubb lkubb requested a review from a team as a code owner March 21, 2022 10:42
@lkubb lkubb requested review from MKLeb and removed request for a team March 21, 2022 10:42
@welcome
Copy link

welcome bot commented Mar 21, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@lkubb lkubb force-pushed the file-malformed-state-return branch from 90703c5 to 19a79ae Compare March 22, 2022 06:54
@lkubb lkubb force-pushed the file-malformed-state-return branch from d5320c6 to b67dd96 Compare April 5, 2022 11:43
@lkubb lkubb force-pushed the file-malformed-state-return branch from b67dd96 to d00fd90 Compare April 15, 2022 08:06
@lkubb lkubb force-pushed the file-malformed-state-return branch from d00fd90 to 3dd114f Compare May 12, 2022 22:54
@lkubb lkubb requested a review from MKLeb May 12, 2022 22:58
@lkubb lkubb force-pushed the file-malformed-state-return branch from 3dd114f to a1fff31 Compare August 23, 2022 05:19
@lkubb
Copy link
Contributor Author

lkubb commented Sep 10, 2022

@MKLeb Anything holding this up now? It should be a simple fix. :)

@MKLeb
Copy link
Contributor

MKLeb commented Sep 10, 2022

Going to update your branch with the newest master changes.

@garethgreenaway garethgreenaway merged commit 81502c2 into saltstack:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKLeb MKLeb MKLeb approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lkubb @MKLeb @garethgreenaway