Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of args to libcloud_storage.download_object module #62075

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

OliElli
Copy link

@OliElli OliElli commented May 17, 2022

What does this PR do?

Fixes the ordering of arguments to the libcloud_storage.download_object module in the libcloud_storage.file_present state

What issues does this PR fix or reference?

Fixes: #62074

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@OliElli OliElli requested a review from a team as a code owner May 17, 2022 13:41
@OliElli OliElli requested review from MKLeb and removed request for a team May 17, 2022 13:41
@welcome
Copy link

welcome bot commented May 17, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@MKLeb
Copy link
Contributor

MKLeb commented May 19, 2022

Hi @OliElli, thanks for your contribution. This will need a changelog, and also a test to go along with this.

@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 1.35s
- exit code: 1

/home/runner/.cache/pre-commit/reposnol2mn8/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:30: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'state_result' on 'salt/states/libcloud_storage.py' does not have a docstring
Found 1 errors


Thanks again!

@MKLeb MKLeb added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Sep 13, 2022
@Ch3LL Ch3LL merged commit 8f27d32 into saltstack:master Oct 11, 2022
@welcome
Copy link

welcome bot commented Oct 11, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] libcloud_storage file_present state returns HTTP 400, module works fine
4 participants