macOS: Fix issue when Homebrew casks's tap is null #62793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when the tap from a Homebrew cask is
null
.This can happen when the cask source is:
homebrew/cask
. For other official formulae, such as fonts, the tap field is filled withhomebrew/cask-fonts
, for example.We append the
tap
value to the package name when full name and short name of a package are the same. We do this for backward compatibility with formulas that install packages as:homebre/cask/firefox
.A typical response from the
brew
interface is:This PR also recovers some tests that were tabulated so they weren't executed.
Related issue: #59439
Previous Behavior
Before this patch, salt fails to check wether a homebrew cask has been installed with the following error:
New Behavior
With the patch applied, packages are successfully installed.
Merge requirements satisfied?
Commits signed with GPG?
Yes