[lxd]: fix container_create not creating devices other than of type disk #63997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2023-03-lxd-fix-container_create_devices
branch
3 times, most recently
from
50fd43f to
18f4b72
Compare
|
@jochumdev tagging you as you are still listed as maintainer (?). |
goapunk
force-pushed
the
jd-2023-03-lxd-fix-container_create_devices
branch
from
18f4b72 to
b161d52
Compare
Ch3LL
suggested changes
Apr 5, 2023
goapunk
force-pushed
the
jd-2023-03-lxd-fix-container_create_devices
branch
from
b161d52 to
03985c4
Compare
goapunk
commented
Apr 6, 2023
goapunk
force-pushed
the
jd-2023-03-lxd-fix-container_create_devices
branch
from
03985c4 to
56cab47
Compare
Ch3LL
approved these changes
Apr 6, 2023
goapunk
force-pushed
the
jd-2023-03-lxd-fix-container_create_devices
branch
from
56cab47 to
dce1eaf
Compare
|
@Ch3LL is there anything blocking this from being merged? Do I need to do anything? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extract the
typeargument intodevice_typeso it's not overwritten bycontainer_device_add.What issues does this PR fix or reference?
Fixes: #63996
Previous Behavior
lxd.container_createwouldn't create devices with type other thandisk.New Behavior
lxd.container_createcorrectly creates devices with any type.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes