Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Fix file client private attribute reference on SaltMakoTemplateLookup #64341

Merged
merged 5 commits into from
May 31, 2023
Merged

[3006.x] Fix file client private attribute reference on SaltMakoTemplateLookup #64341

merged 5 commits into from
May 31, 2023

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

  • Fix file client private attribute reference on SaltMakoTemplateLookup
  • Migrate tests/unit/test_template.py to pytest
  • Migrate tests/unit/utils/test_templates.py to pytest

What issues does this PR fix or reference?

Fixes #64280

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 24, 2023 12:12
@s0undt3ch s0undt3ch requested review from garethgreenaway and removed request for a team May 24, 2023 12:12
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix file client private attribute reference on SaltMakoTemplateLookup [3006.x] Fix file client private attribute reference on SaltMakoTemplateLookup May 24, 2023
@s0undt3ch s0undt3ch force-pushed the hotfix/issues/64280 branch from 95b006b to e3331d6 Compare May 24, 2023 12:19
@s0undt3ch s0undt3ch linked an issue May 24, 2023 that may be closed by this pull request
[BUG] Mako error on pillars render after upgrade to 3006.1 #64280
Closed
9 tasks
@s0undt3ch s0undt3ch added this to the Sulfur v3006.2 milestone May 24, 2023
@s0undt3ch s0undt3ch temporarily deployed to ci May 24, 2023 13:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 24, 2023 13:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 24, 2023 13:45 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch force-pushed the hotfix/issues/64280 branch from e3331d6 to e8f2935 Compare May 25, 2023 08:19
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:35 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:35 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:35 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:35 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:50 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 08:57 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 25, 2023 11:43 — with GitHub Actions Inactive
@Ch3LL Ch3LL merged commit 560ab52 into saltstack:3006.x May 31, 2023
@tacerus tacerus mentioned this pull request Jan 16, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway garethgreenaway was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Sulfur v3006.2
Projects
None yet
Milestone
Sulfur v3006.2
Development

Successfully merging this pull request may close these issues.

[BUG] Mako error on pillars render after upgrade to 3006.1
2 participants
@s0undt3ch @Ch3LL