Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Ensure selinux values are handled lowercase #64352

Merged
merged 8 commits into from
Jun 1, 2023
Merged

[3006.x] Ensure selinux values are handled lowercase #64352

merged 8 commits into from
Jun 1, 2023

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented May 24, 2023 •
edited
Loading

What does this PR do?

Ensures selinux values for SELINUX and SELINUXTYPE are handled lowercase

What issues does this PR fix or reference?

Fixes: #64318

Previous Behavior

SELINUX and SELINUXTYPE were set with an Uppercase leading character, for example: Permissive

New Behavior

SELINUX and SELINUXTYPE are handled lowercase, with any input being forced to lowercase before use and all output is now handled lowercase, for example: permissive.

The /etc/selinux/config file utilizes lowercase inputs.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 requested a review from a team as a code owner May 24, 2023 22:25
@dmurphy18 dmurphy18 requested review from twangboy and removed request for a team May 24, 2023 22:25
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [WIP] Ensure selinux values are handled lowercase [3006.x][WIP] Ensure selinux values are handled lowercase May 24, 2023
@dmurphy18 dmurphy18 added this to the Sulfur v3006.2 milestone May 24, 2023
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 22:42 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 22:43 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 22:43 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 22:48 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 22:57 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:03 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:55 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:56 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 24, 2023 23:56 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 00:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 19:06 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 25, 2023 20:50 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:05 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:05 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:05 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:05 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:18 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 22:22 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:45 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci May 31, 2023 23:52 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:38 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 temporarily deployed to ci June 1, 2023 01:39 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 changed the title [3006.x][WIP] Ensure selinux values are handled lowercase [3006.x] Ensure selinux values are handled lowercase Jun 1, 2023
@dmurphy18 dmurphy18 requested a review from s0undt3ch June 1, 2023 14:10
@Ch3LL Ch3LL merged commit 692447e into saltstack:3006.x Jun 1, 2023
@dmurphy18 dmurphy18 mentioned this pull request Jun 1, 2023
Closed
9 tasks
@dmurphy18 dmurphy18 deleted the fix_64318 branch July 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKLeb MKLeb MKLeb approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@twangboy twangboy Awaiting requested review from twangboy twangboy was automatically assigned from saltstack/team-core

@s0undt3ch s0undt3ch Awaiting requested review from s0undt3ch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sulfur v3006.2
Development

Successfully merging this pull request may close these issues.
4 participants
@dmurphy18 @s0undt3ch @Ch3LL @MKLeb