[master] Upgrade tornado to 6.3.2 #64396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
|
Here is a passing full test run against the branch: https://github.com/saltstack/salt/actions/runs/5130722761 |
whytewolf
approved these changes
May 31, 2023
twangboy
approved these changes
May 31, 2023
s0undt3ch
approved these changes
May 31, 2023
| @@ -28,8 +28,9 @@ def app(client_config, load_auth): | |||
| ) | |||
|
|
|||
|
|
|||
| # The order of these fixtures matter, app before io_loop | |||
There was a problem hiding this comment.
A less brittle solution is to have the app fixture depend on the ioloop fixture.
garethgreenaway
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade tornado to 6.3.2
What issues does this PR fix or reference?
Fixes: #64305
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.