Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Update chocolatey.py / Search for choco.exe #64428

Merged
merged 7 commits into from
Jul 19, 2023
Merged

[master] Update chocolatey.py / Search for choco.exe #64428

merged 7 commits into from
Jul 19, 2023

Conversation

TiHiNi
Copy link
Contributor

@TiHiNi TiHiNi commented Jun 6, 2023 •
edited
Loading

chocolatey.exe was renamed to choco.exe by Chocolatey in Version 2.0.0

What does this PR do?

Add the search for choco.exe to confirm that Chocolatey is installed.

What issues does this PR fix or reference?

Fixes: #64427

Previous Behavior

The module only searched for chocolatey.exe

New Behavior

The module now search for choco.exe, too.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@TiHiNi TiHiNi requested a review from a team as a code owner June 6, 2023 16:24
@TiHiNi TiHiNi requested review from whytewolf and removed request for a team June 6, 2023 16:24
@welcome
Copy link

welcome bot commented Jun 6, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Update chocolatey.py / Search for choco.exe [master] Update chocolatey.py / Search for choco.exe Jun 6, 2023
Ch3LL
Ch3LL suggested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a changelog and test coverage. This would probably be the best place for test coverage: tests/pytests/unit/modules/test_chocolatey.py

@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:15 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:15 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:16 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:33 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:35 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 6, 2023 20:49 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 7, 2023 01:21 — with GitHub Actions Inactive
whytewolf
whytewolf previously approved these changes Jun 8, 2023
View reviewed changes
Ch3LL
Ch3LL previously approved these changes Jun 8, 2023
View reviewed changes
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 19:46 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 19:46 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 19:46 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 19:46 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 20:01 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 20:11 — with GitHub Actions Inactive
@TiHiNi TiHiNi temporarily deployed to ci June 8, 2023 21:12 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch added backport:complete PR Backported labels Jul 19, 2023
@s0undt3ch s0undt3ch mentioned this pull request Jul 19, 2023
Merged
@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

13 similar comments
@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
✅ 3006.x

Questions ?

Please refer to the Backport tool documentation

@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 13:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 13:46 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 14:27 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 14:28 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 14:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 14:49 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci July 19, 2023 21:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmurphy18 dmurphy18 dmurphy18 approved these changes

@twangboy twangboy twangboy approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@whytewolf whytewolf Awaiting requested review from whytewolf

@Ch3LL Ch3LL Awaiting requested review from Ch3LL

Assignees
No one assigned
Labels
backport:complete PR Backported backport:3006.x Backport PR to 3006.x branch Chlorine v3007.0 Sulfur v3006.2
Projects
None yet
Milestone
No milestone
6 participants
@TiHiNi @Ch3LL @s0undt3ch @whytewolf @twangboy @dmurphy18