Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add fallback for when "remounting" NFS or FUSE initially fails #65351

Merged

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Oct 5, 2023

What does this PR do?

When an NFS or FUSE mount fails to unmount when mount options have changed, try again with a lazy umount before mounting again.

What issues does this PR fix or reference?

Fixes: #18907

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner October 5, 2023 15:20
@garethgreenaway garethgreenaway requested review from MKLeb and removed request for a team October 5, 2023 15:20
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Add fallback for when "remounting" NFS or FUSE initially fails [master] Add fallback for when "remounting" NFS or FUSE initially fails Oct 5, 2023
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:37 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:37 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:37 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:37 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:53 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 15:59 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:17 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 5, 2023 18:24 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@garethgreenaway garethgreenaway temporarily deployed to ci October 6, 2023 17:32 — with GitHub Actions Inactive
@dmurphy18 dmurphy18 merged commit a04d09e into saltstack:master Dec 11, 2023
517 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mount.mounted does not completely unmount NFS mounts when options change
4 participants