Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] file.comment ignore_missing not working with multiline char #65552

Merged

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

See issue for details.

What issues does this PR fix or reference?

Fixes: #65501

Previous Behavior

See issue for details.

New Behavior

See issue for details.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner November 14, 2023 21:27
@nicholasmhughes nicholasmhughes requested review from dwoz and removed request for a team November 14, 2023 21:27
@s0undt3ch s0undt3ch merged commit c5fbfa1 into saltstack:master Nov 15, 2023
417 checks passed
@s0undt3ch s0undt3ch added the backport:3006.x Backport PR to 3006.x branch label Nov 15, 2023
Copy link

💔 All backports failed

Status Branch Result
3006.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 65552

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@s0undt3ch
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
3006.x

Questions ?

Please refer to the Backport tool documentation

Copy link

💔 All backports failed

Status Branch Result
complete The branch "complete" does not exist

Manual backport

To create the backport manually run:

backport --pr 65552

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:complete PR Backported backport:3006.x Backport PR to 3006.x branch Chlorine v3007.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] file.comment ignore_missing not working
3 participants