Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Use send_multipart instead of send when sending multipart message. #65681

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

fanaticize
Copy link
Contributor

What does this PR do?

Sometimes publish_payload fails to send the message properly when zmq_filtering is True. I have confirmed that the message transmission with send(topic, flags=zmq.SNDMORE) can be a problem in the asynchronous operation process. Although it is non-deterministic, it has been verified through a test code that finds problems with high probability.

What issues does this PR fix or reference?

Fixes: #65018

Previous Behavior

Send multipart message using send(topic, flags=zmq.SNDMORE)

New Behavior

Send multipart message using send_multipart

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@fanaticize fanaticize requested a review from a team as a code owner December 10, 2023 10:12
@fanaticize fanaticize requested review from dwoz and removed request for a team December 10, 2023 10:12
Copy link

welcome bot commented Dec 10, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@dwoz dwoz added this to the Sulfur v3006.6 milestone Dec 11, 2023
dwoz
dwoz previously approved these changes Dec 12, 2023
@dwoz
Copy link
Contributor

dwoz commented Dec 12, 2023

@fanaticize Can you fix pre-commit please?

@s0undt3ch s0undt3ch self-assigned this Jan 24, 2024
@s0undt3ch s0undt3ch merged commit a395534 into saltstack:3006.x Jan 24, 2024
838 checks passed
Copy link

welcome bot commented Jan 24, 2024

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.6 test:full Run the full test suite test:pkg Run the package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants