-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Use send_multipart instead of send when sending multipart message. #65681
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
@fanaticize Can you fix pre-commit please? |
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Sometimes
publish_payload
fails to send the message properly when zmq_filtering is True. I have confirmed that the message transmission withsend(topic, flags=zmq.SNDMORE)
can be a problem in the asynchronous operation process. Although it is non-deterministic, it has been verified through a test code that finds problems with high probability.What issues does this PR fix or reference?
Fixes: #65018
Previous Behavior
Send multipart message using
send(topic, flags=zmq.SNDMORE)
New Behavior
Send multipart message using send_multipart
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes