Release 16.11.2023 (#852)

.editorconfig

@@ -0,0 +1,12 @@
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+charset = utf-8
+insert_final_newline = true
+trim_trailing_whitespace = true
+indent_size = 4

.github/processing-scope.js

@@ -41,8 +41,11 @@ module.exports = () => {
     const HAS_PLASMA_B2C = packagesList.includes('@salutejs/plasma-b2c');
     const HAS_PLASMA_TEMPLE = packagesList.includes('@salutejs/plasma-temple');
     const HAS_PLASMA_HOPE = packagesList.includes('@salutejs/plasma-new-hope');
+    const HAS_PLASMA_ASDK = packagesList.includes('@salutejs/plasma-asdk');
+    const HAS_PLASMA_WEBSITE = packagesList.includes('@salutejs/plasma-website');
 
-    const HAS_DOCUMENTATION_CHANGED = HAS_PLASMA_UI_DOCS || HAS_PLASMA_WEB_DOCS || HAS_PLASMA_TEMPLE_DOCS;
+    const HAS_DOCUMENTATION_CHANGED =
+        HAS_PLASMA_WEBSITE || HAS_PLASMA_UI_DOCS || HAS_PLASMA_WEB_DOCS || HAS_PLASMA_TEMPLE_DOCS;
 
     /**
      * List short packages name
@@ -74,5 +77,6 @@ module.exports = () => {
         HAS_PLASMA_B2C,
         HAS_PLASMA_TEMPLE,
         HAS_PLASMA_HOPE,
+        HAS_PLASMA_ASDK,
     };
 };

.github/workflows/change-detection.yml

@@ -45,6 +45,9 @@ on:
       HAS_PLASMA_HOPE:
         description: ""
         value: ${{ jobs.run.outputs.HAS_PLASMA_HOPE }}
+      HAS_PLASMA_ASDK:
+        description: ""
+        value: ${{ jobs.run.outputs.HAS_PLASMA_ASDK }}
       PACKAGES_ENUMERATION:
         description: ""
         value: ${{ jobs.run.outputs.PACKAGES_ENUMERATION }}
@@ -63,6 +66,7 @@ jobs:
       HAS_PLASMA_WEB: ${{ steps.set-output.outputs.HAS_PLASMA_WEB }}
       HAS_PLASMA_UI: ${{ steps.set-output.outputs.HAS_PLASMA_UI }}
       HAS_PLASMA_HOPE: ${{ steps.set-output.outputs.HAS_PLASMA_HOPE }}
+      HAS_PLASMA_ASDK: ${{ steps.set-output.outputs.HAS_PLASMA_ASDK }}
       PACKAGES_ENUMERATION: ${{ steps.set-output.outputs.PACKAGES_ENUMERATION }}
 
     steps:
@@ -110,5 +114,6 @@ jobs:
           echo "HAS_PLASMA_WEB=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_WEB }}" >> $GITHUB_OUTPUT
           echo "HAS_PLASMA_UI=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_UI }}" >> $GITHUB_OUTPUT
           echo "HAS_PLASMA_HOPE=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_HOPE }}" >> $GITHUB_OUTPUT
+          echo "HAS_PLASMA_ASDK=${{ fromJSON(steps.scope.outputs.result).HAS_PLASMA_ASDK }}" >> $GITHUB_OUTPUT
           echo "PACKAGES_ENUMERATION=${{ fromJSON(steps.scope.outputs.result).PACKAGES_ENUMERATION }}" >> $GITHUB_OUTPUT
 

.github/workflows/documentation-pr.yml

@@ -153,6 +153,12 @@ jobs:
           npm run storybook:build --prefix="./packages/plasma-new-hope"
           cp -R ./packages/plasma-new-hope/build-sb ./s3_build/${PR_NAME}/new-hope-storybook
 
+      - name: Plasma "ASDK" Storybook
+        if: ${{ needs.scope.outputs.HAS_PLASMA_ASDK == 'true' }}
+        run: |
+          npm run storybook:build --prefix="./packages/plasma-asdk"
+          cp -R ./packages/plasma-asdk/build-sb ./s3_build/${PR_NAME}/asdk-storybook
+
       - name: Install s3cmd
         run: pip3 install s3cmd
 
@@ -179,10 +185,11 @@ jobs:
           HAS_PLASMA_UI: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_UI) }}
           HAS_PLASMA_TEMPLE: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_TEMPLE) }}
           HAS_PLASMA_HOPE: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_HOPE) }}
+          HAS_PLASMA_ASDK: ${{ fromJSON(needs.scope.outputs.HAS_PLASMA_ASDK) }}
         with:
           github-token: ${{secrets.GH_TOKEN}}
           script: |
-            const { HAS_PLASMA_B2C, HAS_PLASMA_WEB, HAS_PLASMA_UI, HAS_PLASMA_TEMPLE, HAS_PLASMA_HOPE } = process.env;
+            const { HAS_PLASMA_B2C, HAS_PLASMA_WEB, HAS_PLASMA_UI, HAS_PLASMA_TEMPLE, HAS_PLASMA_HOPE, HAS_PLASMA_ASDK } = process.env;
                               
             const { 
               issue: { number }, 
@@ -212,6 +219,10 @@ jobs:
             if (HAS_PLASMA_HOPE === 'true') {
               links.push(`new-hope storybook: http://plasma.sberdevices.ru/pr/pr-${number}/new-hope-storybook/`)
             }
+            
+            if (HAS_PLASMA_ASDK === 'true') {
+              links.push(`asdk storybook: http://plasma.sberdevices.ru/pr/pr-${number}/asdk-storybook/`)
+            }
 
             github.rest.issues.createComment({
               issue_number: number,

.github/workflows/performance-test-base.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: ./.github/actions/prepare-environment
 
       - name: Lerna bootstrap
-        run: npx lerna bootstrap --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,ui,icons}
+        run: npx lerna bootstrap --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,asdk,ui,icons}
 
       - name: Install s3cmd
         run: pip3 install s3cmd

.github/workflows/performance-test-pr.yml

@@ -66,7 +66,7 @@ jobs:
       - name: Lerna bootstrap for PR
         run: >
           npx lerna bootstrap
-          --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,ui,icons}
+          --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,asdk,ui,icons}
           --scope=@salutejs/perftest-helpers
 
       - name: Restore perftool cache
@@ -138,7 +138,7 @@ jobs:
       - name: Lerna bootstrap for ${{ github.event.pull_request.base.ref }}
         run: >
           npx lerna bootstrap
-          --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,ui,icons}
+          --scope=@salutejs/plasma-{core,hope,new-hope,web,b2c,asdk,ui,icons}
           --scope=@salutejs/perftest-helpers
 
       - name: Run performance test for ${{ github.event.pull_request.base.ref }}
@@ -161,8 +161,8 @@ jobs:
           name: Component performance comparison result
           path: /home/runner/work/plasma/plasma/perftest/*.json
 
-      - name: Update PR description
-        uses: ./actions/perftest-helpers/actions/update-description
+      - name: Write report comment
+        uses: ./actions/perftest-helpers/actions/write-comment
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           reportPath: /home/runner/work/plasma/plasma/perftest/comparison.json

.prettierignore

@@ -1,10 +1,18 @@
 /node_modules/
-/package.json
-/package-lock.json
 /build
-utils/plasma-cy-utils/lib
+
+# Exclude package(-lock).json for all packages
+package.json
+package-lock.json
+
+# Exclude *.api.md
 packages/plasma-b2c/api/
 packages/plasma-web/api/
 packages/plasma-hope/api/
 packages/plasma-core/api/
+packages/plasma-asdk/api/
+
+utils/plasma-cy-utils/lib
+
+# Exclude *.diff
 reports

actions/perftest-helpers/actions/update-description/action.yml → actions/perftest-helpers/actions/write-comment/action.yml

@@ -1,5 +1,5 @@
-name: Update description with perftest report
-description: Updates description with perftest report summary and details
+name: Writes comment with perftest report
+description: Writes comment with perftest report summary and details
 inputs:
   token:
     description: The GitHub token used to create an authenticated client.
@@ -21,7 +21,7 @@ outputs:
     description: Process done with success.
 runs:
   using: node16
-  main: '../../lib/bin/updateDescription.js'
+  main: '../../lib/bin/writeComment.js'
 branding:
   icon: check-square
   color: purple

actions/perftest-helpers/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@salutejs/perftest-helpers",
-  "version": "0.2.0",
+  "version": "0.3.0-dev.0",
   "description": "Performance test job helpers",
   "author": "Salute Frontend Team <[email protected]>",
   "license": "MIT",
@@ -37,4 +37,4 @@
     "lib",
     "actions"
   ]
-}
+}

actions/perftest-helpers/src/bin/updateDescription.ts → actions/perftest-helpers/src/bin/writeComment.ts

@@ -2,7 +2,7 @@
 import { getInput, setFailed } from '@actions/core';
 import { getOctokit } from '@actions/github';
 
-import PerftestUpdatePRDescriptionApi from '../modules/updateDescription';
+import PerftestWriteCommentApi from '../modules/writeComment';
 
 async function main() {
     const token = getInput('token', { required: true });
@@ -13,7 +13,7 @@ async function main() {
 
     const octokit = getOctokit(token);
 
-    await new PerftestUpdatePRDescriptionApi({ octokit }).update({
+    await new PerftestWriteCommentApi({ octokit }).post({
         reportPath,
         prId,
         owner,

actions/perftest-helpers/src/modules/__snapshots__/writeComment.test.ts.snap

@@ -0,0 +1,34 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`perftest/writeComment getDescriptionTables should iterate through tasks, forming tables with rows 1`] = `
+"
+**taskId1:**
+
+| Component | Diff | Base value | Current value |
+|:-:|:-:|:-:|:-:|
+row
+row
+
+**taskId2:**
+
+| Component | Diff | Base value | Current value |
+|:-:|:-:|:-:|:-:|
+row
+row
+row
+
+**taskId3:**
+
+| Component | Diff | Base value | Current value |
+|:-:|:-:|:-:|:-:|
+row
+"
+`;
+
+exports[`perftest/writeComment getReportDescription should return description markup with report 1`] = `
+"<details><summary>Details</summary><br/>
+report
+</details>"
+`;
+
+exports[`perftest/writeComment getSubjectTaskResultTableRow should format the row 1`] = `"| subjectId | diff (percentage) | old | new1 |"`;